Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to make sure this works with the python controller #9743

Closed
woody-apple opened this issue Sep 16, 2021 · 1 comment
Closed

Followup to make sure this works with the python controller #9743

woody-apple opened this issue Sep 16, 2021 · 1 comment

Comments

@woody-apple
Copy link
Contributor

Because we have these flags in the codebase anyway, we're already de-facto compiling with different flags. They're plumbed through gn normally, but we can compile with ex. different mdns impls etc. But I don't actually think this needs to be Ifdef'd - it seems like you can call StartServer and it will start advertising as a commissioner if that flag is on.

However, I agree with Andrei - it's unclear how you would compile the python controller to enable or disable this functionality.

Originally posted by @cecille in #9603 (comment)

@sharadb-amazon
Copy link
Contributor

PR posted: #9757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants