Adding a way to override feature flags (for commissioner discovery) for Python chip-device-ctrl tool #9757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
requested review from
chrisdecenzo,
erjiaqing and
Damian-Nordic
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
emargolis,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
turon,
vivien-apple and
woody-apple
sharadb-amazon
force-pushed
the
py-conf
branch
from
8b29da7 to
a5cdb0b
Compare
Opened an issue to track this work: #9889 |
hawk248
approved these changes
Sep 22, 2021
woody-apple
approved these changes
Sep 22, 2021
andy31415
pushed a commit
that referenced
this pull request
Sep 23, 2021
…or Python chip-device-ctrl tool (#9757) * Overriding project_config_include_dirs for python chip-device-ctrl tool and setting commissioner discovery flags to 1 * Overriding chip_project_config_include_dirs directly in build_python.sh * Restyled by shfmt Co-authored-by: Restyled.io <[email protected]>
|
This seems to be breaking BLE provisioning in the TE6 branch. Need to remove it from the TE6 branch. |
|
Revert done. |
hank820
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Sep 27, 2021
…or Python chip-device-ctrl tool (project-chip#9757) * Overriding project_config_include_dirs for python chip-device-ctrl tool and setting commissioner discovery flags to 1 * Overriding chip_project_config_include_dirs directly in build_python.sh * Restyled by shfmt Co-authored-by: Restyled.io <[email protected]>
hank820
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Sep 27, 2021
…overy) for Python chip-device-ctrl tool (project-chip#9757)" This reverts commit fd8a17f.
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Sep 27, 2021
…overy) for Python chip-device-ctrl tool (project-chip#9757)" This reverts commit a5731da.
TE-N-ElvenWang
added a commit
to TE-N-ElvenWang/connectedhomeip
that referenced
this pull request
Sep 29, 2021
…overy) for Python chip-device-ctrl tool (project-chip#9757)" This reverts commit fd8a17f.
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 1, 2021
…overy) for Python chip-device-ctrl tool (project-chip#9757)" This reverts commit a5731da.
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 5, 2021
…overy) for Python chip-device-ctrl tool (project-chip#9757)" This reverts commit a5731da.
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 12, 2021
…overy) for Python chip-device-ctrl tool (project-chip#9757)" This reverts commit a5731da.
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 20, 2021
…overy) for Python chip-device-ctrl tool (project-chip#9757)" This reverts commit a5731da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The flags defined in src/platform/include/CHIPDeviceConfig.h could be overriden by various example apps, but not for the python controller. And we needed a way to set the commissioner discovery flags to true for the python controller.
Change overview
Testing
Tested against the minimal-mdns client and verified that the py chip-device-ctrl tool advertises itself as a commissioner after this config change.