-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't clobber chip-tool error #9504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem 82cf1b1 (PR project-chip#9086) could clobber a returned error code with a different value `GetCommandExitStatus()`, which could lead to `chip-tool` exiting successfully when it shouldn't. (This doesn't actually happen at present because nothing sets `err` after `RunCommand()`, but could be triggered by otherwise innocuous code changes.) #### Change overview Check for an existing error in preference to `GetCommandExitStatus()`. #### Testing Manual run of `chip-tool` with edits.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
September 7, 2021 15:01
andy31415
approved these changes
Sep 7, 2021
msandstedt
approved these changes
Sep 7, 2021
Size increase report for "esp32-example-build" from 071592d
Full report output
|
woody-apple
approved these changes
Sep 7, 2021
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Sep 9, 2021
* Don't clobber chip-tool error #### Problem 82cf1b1 (PR project-chip#9086) could clobber a returned error code with a different value `GetCommandExitStatus()`, which could lead to `chip-tool` exiting successfully when it shouldn't. (This doesn't actually happen at present because nothing sets `err` after `RunCommand()`, but could be triggered by otherwise innocuous code changes.) #### Change overview Check for an existing error in preference to `GetCommandExitStatus()`. #### Testing Manual run of `chip-tool` with edits. * stop task before getting status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
82cf1b1 (PR #9086) could clobber a returned error code with a
different value
GetCommandExitStatus()
, which could lead tochip-tool
exiting successfully when it shouldn't. (This doesn't actually happen
at present because nothing sets
err
afterRunCommand()
, but couldbe triggered by otherwise innocuous code changes.)
Change overview
Check for an existing error in preference to
GetCommandExitStatus()
.Testing
Manual run of
chip-tool
with edits.