-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move socket watch APIs into System::Layer #9086
Merged
andy31415
merged 10 commits into
project-chip:master
from
kpschoedel:x7715-system-layer-1
Aug 23, 2021
Merged
Move socket watch APIs into System::Layer #9086
andy31415
merged 10 commits into
project-chip:master
from
kpschoedel:x7715-system-layer-1
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Transitionally, `System::Layer` operations are provided by a configuration-specific `WatchableEventManager`, but they are not yet sufficiently aligned to convert to abstract and implementation classes. Part of project-chip#7715 Virtualize System and Inet interfaces #### Change overview - Move socket event watch APIs into `System::Layer`. - Remove `WatchableSocket` and its include-file hack that allowed implementation-specific state to be contained directly in EndPoints. - Revise the select() implementation to use an internal pool for watch state in place of the EndPoint-embedded WatchableSocket. - Revise the libevent sample implementation to use libevent timers directly instead of the System::Timer pool. The libevent implementation uses STL containers with heap-allocated state for the sake of being different from the select()-based implementation. #### Testing CI; no change to functionality should is expected.
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
sagar-apple,
saurabhst,
selissia,
vivien-apple and
woody-apple
August 17, 2021 14:41
woody-apple
approved these changes
Aug 19, 2021
kpschoedel
force-pushed
the
x7715-system-layer-1
branch
from
August 19, 2021 23:03
5f27728
to
94d8bb2
Compare
Size increase report for "gn_qpg-example-build" from 3acbf59
Full report output
|
Size increase report for "nrfconnect-example-build" from 3acbf59
Full report output
|
Size increase report for "esp32-example-build" from 3acbf59
Full report output
|
msandstedt
approved these changes
Aug 20, 2021
saurabhst
approved these changes
Aug 21, 2021
andy31415
approved these changes
Aug 23, 2021
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Aug 23, 2021
* Move socket watch APIs into System::Layer #### Problem Transitionally, `System::Layer` operations are provided by a configuration-specific `WatchableEventManager`, but they are not yet sufficiently aligned to convert to abstract and implementation classes. Part of project-chip#7715 Virtualize System and Inet interfaces #### Change overview - Move socket event watch APIs into `System::Layer`. - Remove `WatchableSocket` and its include-file hack that allowed implementation-specific state to be contained directly in EndPoints. - Revise the select() implementation to use an internal pool for watch state in place of the EndPoint-embedded WatchableSocket. - Revise the libevent sample implementation to use libevent timers directly instead of the System::Timer pool. The libevent implementation uses STL containers with heap-allocated state for the sake of being different from the select()-based implementation. #### Testing CI; no change to functionality should is expected. * restyle * fix GetCommandExitStatus race * Enforce use of API via System::Layer * also include dispatch case * add LwIP case * restyle
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Sep 7, 2021
#### Problem 82cf1b1 (PR project-chip#9086) could clobber a returned error code with a different value `GetCommandExitStatus()`, which could lead to `chip-tool` exiting successfully when it shouldn't. (This doesn't actually happen at present because nothing sets `err` after `RunCommand()`, but could be triggered by otherwise innocuous code changes.) #### Change overview Check for an existing error in preference to `GetCommandExitStatus()`. #### Testing Manual run of `chip-tool` with edits.
woody-apple
pushed a commit
that referenced
this pull request
Sep 7, 2021
* Don't clobber chip-tool error #### Problem 82cf1b1 (PR #9086) could clobber a returned error code with a different value `GetCommandExitStatus()`, which could lead to `chip-tool` exiting successfully when it shouldn't. (This doesn't actually happen at present because nothing sets `err` after `RunCommand()`, but could be triggered by otherwise innocuous code changes.) #### Change overview Check for an existing error in preference to `GetCommandExitStatus()`. #### Testing Manual run of `chip-tool` with edits. * stop task before getting status
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Sep 9, 2021
* Don't clobber chip-tool error #### Problem 82cf1b1 (PR project-chip#9086) could clobber a returned error code with a different value `GetCommandExitStatus()`, which could lead to `chip-tool` exiting successfully when it shouldn't. (This doesn't actually happen at present because nothing sets `err` after `RunCommand()`, but could be triggered by otherwise innocuous code changes.) #### Change overview Check for an existing error in preference to `GetCommandExitStatus()`. #### Testing Manual run of `chip-tool` with edits. * stop task before getting status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Transitionally,
System::Layer
operations are provided by aconfiguration-specific
WatchableEventManager
, but they are not yetsufficiently aligned to convert to abstract and implementation classes.
Part of #7715 Virtualize System and Inet interfaces
Change overview
System::Layer
.WatchableSocket
and its include-file hack that allowedimplementation-specific state to be contained directly in EndPoints.
state in place of the EndPoint-embedded WatchableSocket.
directly instead of the System::Timer pool. The libevent
implementation uses STL containers with heap-allocated state for the
sake of being different from the select()-based implementation.
Testing
CI; no change to functionality should is expected.