-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the server to organize as a class #9200
Conversation
(cecille): If this is re-called when the window is already open, what should happen?connectedhomeip/src/app/server/Server.cpp Lines 231 to 241 in fe88beb
This comment was generated by todo based on a
|
@woody-apple - src/app/tests/TestCommissionManager.cpp exists now |
ab3aac2
to
22b2498
Compare
beeee90
to
800aaab
Compare
800aaab
to
97b2e16
Compare
The platform memory was intentionally left not deinitialized so that minimal mdns can destructconnectedhomeip/src/app/tests/TestCommissionManager.cpp Lines 134 to 139 in 277bd55
This comment was generated by todo based on a
|
277bd55
to
4b83dd3
Compare
18464ce
to
cf24923
Compare
Size increase report for "nrfconnect-example-build" from 44f8ea7
Full report output
|
Size increase report for "esp32-example-build" from 44f8ea7
Full report output
|
@woody-apple Unit tests added. @andy31415 Pullapprove bot complained |
Size increase report for "gn_qpg-example-build" from 2addf00
Full report output
|
Problem
What is being fixed? Examples:
Server.h
andServer.cpp
itself is not well organized with some functions in namespace and some not. The static variables are added arbitrarily.Change overview
The PR refactors the
Server.cpp
file and aggerates its functions to achip::Server
class.Testing
How was this tested? (at least one bullet point required)
chip-tool
and linux all cluster app. The pairing and control flow works well.Fixes #9521