Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: support creating new ExchangeContext for other protocols #9521

Closed
holbrookt opened this issue Sep 7, 2021 · 0 comments · Fixed by #9200
Closed

Server: support creating new ExchangeContext for other protocols #9521

holbrookt opened this issue Sep 7, 2021 · 0 comments · Fixed by #9200
Labels

Comments

@holbrookt
Copy link
Contributor

Problem

Server.cpp hides access to ExchangeManager and does not provide any public methods for creating a new ExchangeContext or adding other message handlers.

This means a device using Server.cpp cannot start, for example, a BDX exchange (which blocks development of OTA Requestor).

Proposed Solution

One of the following:
A) Inject dependencies by adding ExchangeManager and others to Server init arguments (instead of being static inside Server.cpp)
B) Provide an access method for getting a pointer/reference to the ExchangeManager
C) Provide a public method that returns a new ExchangeContext for a given protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant