Revert "[build] Wrap BuildConfig.h in HAVE_CONFIG_H. (#904)" #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c75a3e.
sagar-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
saurabhst
approved these changes
May 29, 2020
woody-apple
approved these changes
May 29, 2020
|
@turon, the xcode build doesn't work with this change...
|
|
Is there a way we can add this to CI if it isn't already? |
gerickson
approved these changes
May 29, 2020
Filed this for iOS fwk CI |
woody-apple
pushed a commit
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6c75a3e.
Problem
The xcode project doesn't build anymore
Summary of Changes
revert change that introduced regression.