fix Xcode builds #920
Merged
fix Xcode builds #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalker-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
Closed
rwalker-apple
force-pushed
the
fix-macOS-build
branch
from
593b50f to
0ea5202
Compare
woody-apple
approved these changes
May 29, 2020
sagar-apple
reviewed
May 29, 2020
|
@rwalker-apple, we need to unrevert #904 (reverted in #919) |
rwalker-apple
force-pushed
the
fix-macOS-build
branch
from
0ea5202 to
af36b80
Compare
gerickson
approved these changes
May 29, 2020
saurabhst
approved these changes
May 29, 2020
turon
approved these changes
May 29, 2020
added 2 commits
May 29, 2020 13:47
…(#918)" This reverts commit 83969661087bc028e8389f29b4c53efd89819b8f.
rwalker-apple
force-pushed
the
fix-macOS-build
branch
from
af36b80 to
5183f88
Compare
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem(s)
Xcode builds broke with HAVE_CONFIG_H
macOS builds not using project config header
Xcode script is skipped when libraries are present (requiring clean build)
Summary of Changes
fixes for the above
fixes #919