Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Expose BLE connection related and commissioning complete events to the application #9041

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

sweetymhaiske
Copy link
Contributor

@sweetymhaiske sweetymhaiske commented Aug 16, 2021

Problem

  • BLE connection-related event and commissioning complete event is not sent to the application.

Change overview

  • Expose CHIPoBLE connect, disconnect and commissioning complete events to the application.

Testing

Build all-clusters-app, flash, and performed commissioning.

@pullapprove pullapprove bot requested a review from mspang August 30, 2021 11:09
@sweetymhaiske sweetymhaiske marked this pull request as draft August 30, 2021 13:46
@sweetymhaiske sweetymhaiske force-pushed the ble_deinit branch 2 times, most recently from a310572 to 0e960bf Compare August 31, 2021 07:03
@sweetymhaiske sweetymhaiske changed the title ESP32: Deinitialize memory for ble after successful commissioning ESP32: Expose BLE connection related and commissioning complete events to the application Aug 31, 2021
@sweetymhaiske sweetymhaiske marked this pull request as ready for review August 31, 2021 07:36
@dhrishi
Copy link
Contributor

dhrishi commented Sep 1, 2021

@sweetymhaiske Please resolve the conflicts and rebase. Also, for now, I am okay if only the events are exposed to the application and the deinit stuff is not done.

@sweetymhaiske
Copy link
Contributor Author

PR is ready.

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Size increase report for "esp32-example-build" from 2ccdcc1

File Section File VM
chip-temperature-measurement-app.elf .flash.text 48 48
chip-lock-app.elf .flash.text 16 16
chip-all-clusters-app.elf .flash.rodata 208 208
chip-all-clusters-app.elf .flash.text 124 124
chip-shell.elf .flash.text -32 -32
chip-bridge-app.elf .flash.text -32 -32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_line,0,95
.debug_info,0,75
.flash.text,48,48
.debug_loc,0,37
.debug_ranges,0,24
.debug_str,0,17
[Unmapped],0,-48

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_line,0,95
.debug_info,0,75
.debug_ranges,0,24
.debug_loc,0,21
.debug_str,0,17
.flash.text,16,16
[Unmapped],0,-16

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,427
.debug_loc,0,271
.flash.rodata,208,208
.flash.text,124,124
.debug_info,0,105
.debug_ranges,0,32
.debug_str,0,16
.debug_frame,0,4
.riscv.attributes,0,-3
[Unmapped],0,-332

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_line,0,95
.debug_info,0,75
[Unmapped],0,32
.debug_loc,0,29
.debug_ranges,0,24
.debug_str,0,17
.flash.text,-32,-32

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_line,0,95
.debug_info,0,75
[Unmapped],0,32
.debug_loc,0,29
.debug_ranges,0,24
.debug_str,0,17
.flash.text,-32,-32


@bzbarsky-apple
Copy link
Contributor

If proper functioning of this code requires a CommissioningComplete command, we should change all commissioners to send it consistently, not just the Python one....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants