-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Expose BLE connection related and commissioning complete events to the application #9041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4607934
to
0346b99
Compare
woody-apple
approved these changes
Aug 16, 2021
examples/temperature-measurement-app/esp32/main/DeviceCallbacks.cpp
Outdated
Show resolved
Hide resolved
0346b99
to
972af2e
Compare
andy31415
reviewed
Aug 16, 2021
andy31415
approved these changes
Aug 16, 2021
dhrishi
reviewed
Aug 16, 2021
a012d50
to
0eccc9e
Compare
aecf21c
to
dabfdb6
Compare
dabfdb6
to
150b156
Compare
e707ee7
to
8b80d3b
Compare
953384b
to
be06586
Compare
a310572
to
0e960bf
Compare
dhrishi
reviewed
Aug 31, 2021
jmartinez-silabs
approved these changes
Aug 31, 2021
@sweetymhaiske Please resolve the conflicts and rebase. Also, for now, I am okay if only the events are exposed to the application and the deinit stuff is not done. |
711514d
to
c0178f8
Compare
006f411
to
65a9ae1
Compare
dhrishi
approved these changes
Sep 1, 2021
… to the application.
65a9ae1
to
d57cf77
Compare
PR is ready. |
Size increase report for "esp32-example-build" from 2ccdcc1
Full report output
|
If proper functioning of this code requires a CommissioningComplete command, we should change all commissioners to send it consistently, not just the Python one.... |
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Sep 24, 2021
… to the application. (project-chip#9041)
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Sep 27, 2021
… to the application. (project-chip#9041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
Build all-clusters-app, flash, and performed commissioning.