Removed duplicate code in controller execution that sends CommissioningComplete #10000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngComplete message to device
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
vivien-apple
This was
linked to
issues
Sep 27, 2021
bzbarsky-apple
approved these changes
Sep 27, 2021
andy31415
approved these changes
Sep 28, 2021
Damian-Nordic
approved these changes
Sep 28, 2021
saurabhst
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Combination of #9041 and #9892 caused a regression at resolve step on certain boards because CommissioningComplete event was sent twice to the device
Change overview
Removed code in resolve step that artificially sends CommissioningComplete to device
Testing