More revisions to System::Layer #8417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem #### Change overview - Removed `SystemLayer.mPlatformData`, which was never set or used, along with associated functions. - Removed `SystemLayer.mContext`, which was set but never used, along with associated function arguments. - Removed `CHIP_SYSTEM_CONFIG_PLATFORM_PROVIDES_XTOR_FUNCTIONS` and associated functions, which were never used. - Rearrangements to group LwIP-specific code together. - project-chip#8267 review followup: rename namespace EventSupport to Eventing #### Testing Successful builds should confirm unused code is unused. Sanity check using chip-tool.
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
sagar-apple,
saurabhst,
selissia,
vivien-apple and
woody-apple
andy31415
approved these changes
Jul 15, 2021
Damian-Nordic
approved these changes
Jul 15, 2021
bzbarsky-apple
approved these changes
Jul 16, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
#### Problem #### Change overview - Removed `SystemLayer.mPlatformData`, which was never set or used, along with associated functions. - Removed `SystemLayer.mContext`, which was set but never used, along with associated function arguments. - Removed `CHIP_SYSTEM_CONFIG_PLATFORM_PROVIDES_XTOR_FUNCTIONS` and associated functions, which were never used. - Rearrangements to group LwIP-specific code together. - project-chip#8267 review followup: rename namespace EventSupport to Eventing #### Testing Successful builds should confirm unused code is unused. Sanity check using chip-tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
System::Layer has unused code.
Change overview
Removed
SystemLayer.mPlatformData, which was never set or used,along with associated functions.
Removed
SystemLayer.mContext, which was set but never used,along with associated function arguments.
Removed
CHIP_SYSTEM_CONFIG_PLATFORM_PROVIDES_XTOR_FUNCTIONSand associated functions, which were never used.
Rearrangements to group LwIP-specific code together.
Revisions to System::Layer #8267 review followup: rename namespace EventSupport to Eventing
Testing
Successful builds should confirm unused code is unused.
Sanity check using chip-tool.