-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisions to System::Layer #8267
Revisions to System::Layer #8267
Conversation
#### Problem `System::Layer` has redundancy in event configuration, and a confusingly-named grab-bag namespace `System::Platform::Layer` This is a standalone fragment of work toward event/threading refactoring, issue project-chip#7725. #### Change overview - Merge `CHIP_SYSTEM_CONFIG_LWIP_EVENT_OBJECT_TYPE` with `CHIP_SYSTEM_CONFIG_EVENT_OBJECT_TYPE`, and `CHIP_SYSTEM_CONFIG_LWIP_EVENT_TYPE` with `CHIP_SYSTEM_CONFIG_EVENT_TYPE`, since they serve the same purpose in LwIP and non-LwIP implementations respectively. - Remove some dead configuration code. - Move event functions from the `System::Platform::Layer` namespace (not the same kind of ‘layer’ as `System::Layer`) to a specific `System::Platform::EventSupport` namespace. - Move (Will|Did)(Init|Shutdown) functions from the `System::Platform::Layer` namespace up to `System::Platform`. #### Testing No functional changes, only renaming and pruning.
|
||
namespace Platform { | ||
namespace Layer { | ||
namespace EventSupport { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: do we need "Support" in the name here? I generally claim that support/helper/core/util and similar naming do not add significant readability. Could we get around with just "Eventing" or "Events" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will rename in the next PR.
Size increase report for "esp32-example-build" from cbf106e
Full report output
|
#### Problem #### Change overview - Removed `SystemLayer.mPlatformData`, which was never set or used, along with associated functions. - Removed `SystemLayer.mContext`, which was set but never used, along with associated function arguments. - Removed `CHIP_SYSTEM_CONFIG_PLATFORM_PROVIDES_XTOR_FUNCTIONS` and associated functions, which were never used. - Rearrangements to group LwIP-specific code together. - project-chip#8267 review followup: rename namespace EventSupport to Eventing #### Testing Successful builds should confirm unused code is unused. Sanity check using chip-tool.
#### Problem #### Change overview - Removed `SystemLayer.mPlatformData`, which was never set or used, along with associated functions. - Removed `SystemLayer.mContext`, which was set but never used, along with associated function arguments. - Removed `CHIP_SYSTEM_CONFIG_PLATFORM_PROVIDES_XTOR_FUNCTIONS` and associated functions, which were never used. - Rearrangements to group LwIP-specific code together. - #8267 review followup: rename namespace EventSupport to Eventing #### Testing Successful builds should confirm unused code is unused. Sanity check using chip-tool.
* Revisions to System::Layer #### Problem `System::Layer` has redundancy in event configuration, and a confusingly-named grab-bag namespace `System::Platform::Layer` This is a standalone fragment of work toward event/threading refactoring, issue project-chip#7725. #### Change overview - Merge `CHIP_SYSTEM_CONFIG_LWIP_EVENT_OBJECT_TYPE` with `CHIP_SYSTEM_CONFIG_EVENT_OBJECT_TYPE`, and `CHIP_SYSTEM_CONFIG_LWIP_EVENT_TYPE` with `CHIP_SYSTEM_CONFIG_EVENT_TYPE`, since they serve the same purpose in LwIP and non-LwIP implementations respectively. - Remove some dead configuration code. - Move event functions from the `System::Platform::Layer` namespace (not the same kind of ‘layer’ as `System::Layer`) to a specific `System::Platform::EventSupport` namespace. - Move (Will|Did)(Init|Shutdown) functions from the `System::Platform::Layer` namespace up to `System::Platform`. #### Testing No functional changes, only renaming and pruning. * restyle * zap regen
#### Problem #### Change overview - Removed `SystemLayer.mPlatformData`, which was never set or used, along with associated functions. - Removed `SystemLayer.mContext`, which was set but never used, along with associated function arguments. - Removed `CHIP_SYSTEM_CONFIG_PLATFORM_PROVIDES_XTOR_FUNCTIONS` and associated functions, which were never used. - Rearrangements to group LwIP-specific code together. - project-chip#8267 review followup: rename namespace EventSupport to Eventing #### Testing Successful builds should confirm unused code is unused. Sanity check using chip-tool.
Problem
System::Layer
has redundancy in event configuration,and a confusingly-named grab-bag namespace
System::Platform::Layer
This is a standalone fragment of work toward event/threading
refactoring, issue #7725.
Change overview
CHIP_SYSTEM_CONFIG_LWIP_EVENT_OBJECT_TYPE
withCHIP_SYSTEM_CONFIG_EVENT_OBJECT_TYPE
, andCHIP_SYSTEM_CONFIG_LWIP_EVENT_TYPE
withCHIP_SYSTEM_CONFIG_EVENT_TYPE
, since they serve the same purposein LwIP and non-LwIP implementations respectively.
System::Platform::Layer
namespace(not the same kind of ‘layer’ as
System::Layer
) to a specificSystem::Platform::EventSupport
namespace.System::Platform::Layer
namespace up toSystem::Platform
.Testing
No functional changes, only renaming and pruning.