Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename OTA Server -> OTA Provider and OTA Client -> OTA Requestor #7920

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Rename OTA Server -> OTA Provider and OTA Client -> OTA Requestor #7920

merged 3 commits into from
Jun 30, 2021

Conversation

holbrookt
Copy link
Contributor

Problem

Change overview

Rename all code references of Server and Client in context of OTA Clusters.

Testing

  • ran unit tests
  • confirmed chip-tool and all-clusters-app build with the right names and can still send cluster commands

@holbrookt holbrookt added the spec Mismatch between spec and implementation label Jun 25, 2021
@woody-apple
Copy link
Contributor

@saurabhst @msandstedt @Damian-Nordic @jepenven-silabs @mspang ?

@woody-apple
Copy link
Contributor

@holbrookt has conflicts :(

@holbrookt
Copy link
Contributor Author

@holbrookt has conflicts :(

Fixed!

@msandstedt msandstedt merged commit e1c906e into project-chip:master Jun 30, 2021
@holbrookt holbrookt deleted the ota-rename branch June 30, 2021 17:53
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@holbrookt
Rename OTA Server -> OTA Provider and OTA Client -> OTA Requestor (pr…
aef4039 
…oject-chip#7920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelderton jelderton jelderton approved these changes

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@msandstedt msandstedt msandstedt approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app controller examples review - approved spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename OTA Server/Client to Provider/Requestor
5 participants
@holbrookt @woody-apple @msandstedt @saurabhst @jelderton