-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster] Add TestUnknownCommand command to test cluster[TE3] #7269
Merged
woody-apple
merged 2 commits into
project-chip:master
from
erjiaqing:feature/test-cluster-non-exist-command
Jun 2, 2021
Merged
[cluster] Add TestUnknownCommand command to test cluster[TE3] #7269
woody-apple
merged 2 commits into
project-chip:master
from
erjiaqing:feature/test-cluster-non-exist-command
Jun 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
sagar-apple
June 1, 2021 09:40
msandstedt
approved these changes
Jun 1, 2021
/rebase |
woody-apple
force-pushed
the
feature/test-cluster-non-exist-command
branch
from
June 1, 2021 20:47
aebb4d6
to
71cec4a
Compare
yunhanw-google
changed the title
[cluster] Add TestUnknownCommand command to test cluster
[cluster] Add TestUnknownCommand command to test cluster[TE3]
Jun 1, 2021
yunhanw-google
approved these changes
Jun 1, 2021
bzbarsky-apple
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there CI exercising this? If not, can we add some, so we don't have to do manual testing?
Create this #7293 for tracking |
jmartinez-silabs
approved these changes
Jun 2, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…t-chip#7269) * [zap] Add TestUnknownCommand * Run Codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
zcl TestCluster TestUnknownCommand 1 1 0
CHIP:ZCL: Unknown command 3 for cluster 50f