Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster] Add TestUnknownCommand command to test cluster[TE3] #7269

Conversation

erjiaqing
Copy link
Contributor

Problem

  • We need a suitable case for test device behavior of unsupported command on a supported cluster.

Change overview

  • Add TestUnknownCommand, this command should not be added / implemented by server.

Testing

  • Tested locally with chip-device-ctrl with all-cluster-apps
  • zcl TestCluster TestUnknownCommand 1 1 0
  • Verify device controller output and server output.
    • Server prints CHIP:ZCL: Unknown command 3 for cluster 50f
    • Controller prints
    CHIP:DMG:               CommandDataElement =
    CHIP:DMG:               {
    CHIP:DMG:                       CommandPath =
    CHIP:DMG:                       {
    CHIP:DMG:                               EndpointId = 0x1,
    CHIP:DMG:                               ClusterId = 0x50f,
    CHIP:DMG:                               CommandId = 0x3,
    CHIP:DMG:                       },
    CHIP:DMG: 
    CHIP:DMG:                       StatusElement =
    CHIP:DMG:                       {
    CHIP:DMG:                               GeneralCode = 0xd,
    CHIP:DMG:                               ProtocolId = 0x0,
    CHIP:DMG:                               protocolCode = 0xffff,
    CHIP:DMG:                       },
    CHIP:DMG: 
    CHIP:DMG:               },
    

@yunhanw-google
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the feature/test-cluster-non-exist-command branch from aebb4d6 to 71cec4a Compare June 1, 2021 20:47
@yunhanw-google yunhanw-google changed the title [cluster] Add TestUnknownCommand command to test cluster [cluster] Add TestUnknownCommand command to test cluster[TE3] Jun 1, 2021
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there CI exercising this? If not, can we add some, so we don't have to do manual testing?

@yunhanw-google
Copy link
Contributor

Is there CI exercising this? If not, can we add some, so we don't have to do manual testing?

Create this #7293 for tracking

@woody-apple
Copy link
Contributor

@woody-apple woody-apple merged commit 9565442 into project-chip:master Jun 2, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants