[python/dns-sd] Fix Python CHIP Controller crash due to mdns initialization #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After project-chip#5956 has been merged, the device controller works as a Resolver delegate, so no separate DeviceAddressUpdater is needed. In fact, they interfere which each other. Switch Python CHIP controller to using the mechanisms introduced by project-chip#5956, fix a couple of issues and remove no longer necessary code.
Damian-Nordic
changed the title
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst,
vivien-apple,
woody-apple and
yufengwangca
Damian-Nordic
changed the title
jmartinez-silabs
approved these changes
Apr 15, 2021
woody-apple
approved these changes
Apr 15, 2021
|
Crash, marking hotfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #5956 has been merged, the device controller works as a Resolver delegate, so no separate DeviceAddressUpdater is
needed. In fact, they interfere which each other and cause Python CHIP Controller to crash on startup.
Summary of Changes
Switch Python CHIP controller to using the mechanisms introduced by #5956, fix a couple of issues and remove no
longer necessary code.