Mdns device controller update device #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
mspang
vivien-apple
force-pushed
the
Mdns_DeviceControllerUpdateDevice
branch
from
c51a32e to
803912d
Compare
msandstedt
reviewed
Apr 12, 2021
|
|
||
| CHIP_ERROR Run(PersistentStorage & storage, NodeId localId, NodeId remoteId) override | ||
| /////////// DiscoverCommand Interface ///////// | ||
| CHIP_ERROR RunCommand(NodeId remoteId, uint64_t fabricId) override |
There was a problem hiding this comment.
Would a better name for this simply be Resolve, or perhaps Discover?
There was a problem hiding this comment.
Pretty sure it's this way as it follows the current RunCommand/Run style of the class (Resolve).
jelderton
approved these changes
Apr 12, 2021
woody-apple
approved these changes
Apr 12, 2021
|
|
||
| CHIP_ERROR Run(PersistentStorage & storage, NodeId localId, NodeId remoteId) override | ||
| /////////// DiscoverCommand Interface ///////// | ||
| CHIP_ERROR RunCommand(NodeId remoteId, uint64_t fabricId) override |
There was a problem hiding this comment.
Pretty sure it's this way as it follows the current RunCommand/Run style of the class (Resolve).
msandstedt
approved these changes
Apr 12, 2021
Damian-Nordic
approved these changes
Apr 13, 2021
Damian-Nordic
added a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Apr 15, 2021
After project-chip#5956 has been merged, the device controller works as a Resolver delegate, so no separate DeviceAddressUpdater is needed. In fact, they interfere which each other. Switch Python CHIP controller to using the mechanisms introduced by project-chip#5956, fix a couple of issues and remove no longer necessary code.
woody-apple
pushed a commit
that referenced
this pull request
Apr 15, 2021
After #5956 has been merged, the device controller works as a Resolver delegate, so no separate DeviceAddressUpdater is needed. In fact, they interfere which each other. Switch Python CHIP controller to using the mechanisms introduced by #5956, fix a couple of issues and remove no longer necessary code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the device IP change, the pairing information needs to be updated. This PR adds
DeviceController::UpdateDeviceto theDeviceControllerin order to look overMdnsfor the latest device information.For the moment, the signature is
UpdateDevice(Device * device, uint64_t fabricId)since the fabric is not stored anywhere but it is needed in order to properly do the Mdns mapping. At some point thefabricIdwill likely be retrieved from the controller or something similar.This PR also add a
updatemethod tochip-toolin order to update the pairing information if needed.Summary of Changes
DeviceController::UpdateDevice(Device * device, uint64_t fabricId);updatemethod to theDiscovermodule ofchip-tool