revert_PR5938 which crash all cirque integration test

[yunhanw-google]

Summary of Changes:
See the consistent crash when running all cirque integration test, after reverting #5938, issue goes away
for example, in echo test,
/out/debug/linux_x64_clang/chip-echo-requester 100.96.158.129
./out/debug/linux_x64_clang/chip-echo-responder

CHIP:EM: Sending Standalone Ack for MsgId:00000000

Thread 8 "chip-echo-reque" received signal SIGABRT, Aborted.
[Switching to Thread 0x7fffe77fe700 (LWP 1467642)]
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007ffff7522537 in __GI_abort () at abort.c:79
#2 0x00005555555e2b64 in chip::Messaging::ExchangeContext::SendMessageImpl(chip::Protocols::Id, unsigned char, chip::System::PacketBufferHandle, chip::BitFlags<chip::Messaging::SendMessageFlags, unsigned short> const&, chip::Transport::PeerConnectionState*)
(this=0x55555563c368 <gExchangeManager+520>, protocolId=..., msgType=16 '\020', msgBuf=..., sendFlags=..., state=0x55555563d310 <(anonymous namespace)::gSessionManager+32>)
at ../../src/messaging/ExchangeContext.cpp:119
#3 0x00005555555e2a53 in chip::Messaging::ExchangeContext::SendMessage(chip::Protocols::Id, unsigned char, chip::System::PacketBufferHandle, chip::BitFlags<chip::Messaging::SendMessageFlags, unsigned short> const&) (this=0x55555563c368 <gExchangeManager+520>, protocolId=..., msgType=16 '\020', msgBuf=..., sendFlags=...) at ../../src/messaging/ExchangeContext.cpp:107

fixes #6032

[github-actions]

Size increase report for "nrfconnect-example-build" from 672cf76

File	Section	File	VM
chip-lighting.elf	datas	12	12
chip-lighting.elf	device_handles	-4	-4
chip-lighting.elf	devices	-4	-4
chip-lighting.elf	[LOAD #3 [RW]]	0	-23
chip-lighting.elf	bss	0	-137
chip-lighting.elf	rodata	-576	-576
chip-lighting.elf	text	-1036	-1036
chip-lock.elf	datas	12	12
chip-lock.elf	devices	4	4
chip-lock.elf	device_handles	-4	-4
chip-lock.elf	[LOAD #3 [RW]]	0	-31
chip-lock.elf	bss	0	-129
chip-lock.elf	rodata	-576	-572
chip-lock.elf	text	-1036	-1036
chip-shell.elf	device_handles	-4	-4
chip-shell.elf	bss	0	-9
chip-shell.elf	[LOAD #3 [RW]]	0	-23
chip-shell.elf	rodata	-744	-748
chip-shell.elf	text	-1292	-1292

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
datas,12,12
.shstrtab,0,-2
device_handles,-4,-4
devices,-4,-4
[LOAD #3 [RW]],-23,0
bss,-137,0
.debug_aranges,0,-392
rodata,-576,-576
.debug_ranges,0,-736
text,-1036,-1036
.debug_frame,0,-1100
.debug_loc,0,-1215
.symtab,0,-1600
.strtab,0,-3670
.debug_str,0,-5749
.debug_abbrev,0,-12327
.debug_line,0,-16355
.debug_info,0,-182126

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
datas,12,12
devices,4,4
.shstrtab,0,2
device_handles,-4,-4
[LOAD #3 [RW]],-31,0
bss,-129,0
.debug_aranges,0,-392
rodata,-572,-576
.debug_ranges,0,-736
text,-1036,-1036
.debug_frame,0,-1100
.debug_loc,0,-1214
.symtab,0,-1600
.strtab,0,-3670
.debug_str,0,-5738
.debug_abbrev,0,-12327
.debug_line,0,-16339
.debug_info,0,-182090

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.shstrtab,0,-1
device_handles,-4,-4
bss,-9,0
[LOAD #3 [RW]],-23,0
.debug_aranges,0,-376
rodata,-748,-744
.debug_ranges,0,-1024
.debug_frame,0,-1068
text,-1292,-1292
.symtab,0,-1392
.strtab,0,-3035
.debug_loc,0,-4091
.debug_str,0,-4857
.debug_abbrev,0,-11101
.debug_line,0,-14573
.debug_info,0,-129358

[Damian-Nordic]

Thanks, I also noticed that the reverted changes cause the following error while commissioning a Nordic DK using the Python controller:

CHIP:EM: OnMessageReceived failed, err = CHIP Error 4112 (0x00001010): Unsolicited msg with originator bit clear

[pan-apple]

Looking into the crash. Please hold off on merging this PR.

[woody-apple]

Blocking this PR for now, we should fix the issue, not pull things out needed for TE2

[woody-apple]

@pan-apple to investigate

[pan-apple]

I've submitted the fix in this PR #6053
I have tested that the IM initiator/responder work with this change.

[yunhanw-google]

Thanks. @pan-apple just close this PR