-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set exchange delegate for app message send #6027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a placeholder delegate for exchange context created in Device::SendMessage()connectedhomeip/src/app/util/chip-message-send.cpp Lines 42 to 52 in 8adbc6b
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst,
wehale,
woody-apple and
yufengwangca
April 14, 2021 23:43
This is breaking the build, tagging. |
Size increase report for "nrfconnect-example-build" from 362c5f2
Full report output
|
Size increase report for "esp32-example-build" from 362c5f2
Full report output
|
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Apr 15, 2021
This reverts commit 9eaec87.
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Apr 15, 2021
This reverts commit 9eaec87.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The command's response from the device is not being sent.
Summary of Changes
#5938 introduced concept of exchange message dispatch. During rework of the code, the default dispatch object was removed. The app-sender need to set the delegate explicitly to be able to send the message thru default dispatch.
Also, removed a log that got added as part of debugging.