-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate KVS with device session tables #4976
Conversation
The admin ID space allocation should be re-evaluated. With the current approach, the space could beconnectedhomeip/src/app/server/Server.cpp Lines 130 to 140 in 4ada40b
This comment was generated by todo based on a
|
4ada40b
to
36cbd80
Compare
rebased |
Size increase report for "nrfconnect-example-build" from 7c09658
Full report output
|
Size increase report for "gn_qpg6100-example-build" from 7c09658
Full report output
|
friend class KeyValueStoreManager; | ||
|
||
public: | ||
// NOTE: Currently this platform does not support partial and offset reads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this comment needs to be updated to state that every function returns NOT_IMPLEMENTED (same on other platforms), or maybe just a comment/TODO on the class to explain.
Problem
The previous PR (#4952) was reverted due to a crash loop on the device.
Summary of Changes
This PR fixes the crash issue caused by #4952. The crash was due to using
MemoryAlloc
instead ofNew<>
for allocating PASESession objects. It caused memory to be allocated, but the object was not initialized.The old PR added the following functionality:
Added code to store relevant information for Admin and Peer Connection/PASE Session in KVS storage. The device will read KVS and recreate the tables at boot up. Tested the change on m5stack.