-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate KVS with device session tables #4952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang,
rwalker-apple,
saurabhst,
vivien-apple and
woody-apple
February 20, 2021 00:13
pan-apple
force-pushed
the
kvs-integration
branch
from
February 20, 2021 00:33
6de6c28
to
af8c8d7
Compare
msandstedt
reviewed
Feb 20, 2021
msandstedt
reviewed
Feb 20, 2021
msandstedt
reviewed
Feb 20, 2021
The admin ID space allocation should be re-evaluated. With the current approach, the space could beconnectedhomeip/src/app/server/Server.cpp Lines 116 to 126 in 48d1400
This comment was generated by todo based on a
|
Size increase report for "gn_qpg6100-example-build" from 2b58bdf
Full report output
|
Size increase report for "nrfconnect-example-build" from 2b58bdf
Full report output
|
andy31415
reviewed
Feb 22, 2021
pan-apple
force-pushed
the
kvs-integration
branch
from
February 22, 2021 16:06
ff40808
to
f080e72
Compare
msandstedt
approved these changes
Feb 22, 2021
jelderton
approved these changes
Feb 22, 2021
andy31415
approved these changes
Feb 22, 2021
woody-apple
approved these changes
Feb 23, 2021
mspang
added a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to persist session and admin information on the device.
Summary of Changes
Added code to store relevant information for Admin and Peer Connection/PASE Session in KVS storage. The device will read KVS and recreate the tables at boot up. Tested the change on m5stack.