Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QPG6100] Add initial lighting app version #4958

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

jimlyall-q
Copy link
Contributor

@jimlyall-q jimlyall-q commented Feb 22, 2021

Problem

There is currently no lighting app available for qpg6100

Summary of Changes

  • Added lighting-app in examples/lighting-app/qpg6100
  • Enable OpenThread support

@todo
Copy link

todo bot commented Feb 22, 2021

PR # 2939 - OT support

// TODO: PR # 2939 - OT support
// SetDeviceName("QPG6100LightingDemo._chip._udp.local.");
while (true)
{
BaseType_t eventReceived = xQueueReceive(sAppEventQueue, &event, pdMS_TO_TICKS(10));
while (eventReceived == pdTRUE)
{
sAppTask.DispatchEvent(&event);
eventReceived = xQueueReceive(sAppEventQueue, &event, 0);
}


This comment was generated by todo based on a TODO comment in a49971d in #4958. cc @jimlyall-q.

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2021

CLA assistant check
All committers have signed the CLA.

@todo
Copy link

todo bot commented Feb 22, 2021

PR # 2939 - OT support

// TODO: PR # 2939 - OT support
/*
PublishService();
*/
mLastChangeTimeUS = nowUS;
}
}
}


This comment was generated by todo based on a TODO comment in a49971d in #4958. cc @jimlyall-q.

@todo
Copy link

todo bot commented Feb 22, 2021

hijacked the function button to change level

// TODO hijacked the function button to change level
button_event.Type = AppEvent::kEventType_Level;
button_event.Handler = LightingActionEventHandler;
sAppTask.PostEvent(&button_event);
}
}
void AppTask::TimerEventHandler(chip::System::Layer * aLayer, void * aAppState, chip::System::Error aError)
{
AppEvent event;
event.Type = AppEvent::kEventType_Timer;


This comment was generated by todo based on a TODO comment in a49971d in #4958. cc @jimlyall-q.

@todo
Copy link

todo bot commented Feb 22, 2021

understand well enough to implement the level cluster ZCL_CURRENT_LEVEL_ATTRIBUTE_ID

// TODO understand well enough to implement the level cluster ZCL_CURRENT_LEVEL_ATTRIBUTE_ID
status = emberAfWriteAttribute(1, ZCL_LEVEL_CONTROL_CLUSTER_ID, ZCL_CURRENT_LEVEL_ATTRIBUTE_ID, CLUSTER_MASK_SERVER,
(uint8_t *) &newValue, ZCL_DATA8_ATTRIBUTE_TYPE);
if (status != EMBER_ZCL_STATUS_SUCCESS)
{
ChipLogError(NotSpecified, "ERR: updating level %x", status);
}
}


This comment was generated by todo based on a TODO comment in a49971d in #4958. cc @jimlyall-q.

@todo
Copy link

todo bot commented Feb 22, 2021

this function is called InitiateAction because we want to implement some features such as ramping up here.

// TODO: this function is called InitiateAction because we want to implement some features such as ramping up here.
bool action_initiated = false;
State_t new_state;
switch (aAction)
{
case ON_ACTION:
ChipLogProgress(NotSpecified, "LightingManager::InitiateAction(ON_ACTION)");
break;
case OFF_ACTION:
ChipLogProgress(NotSpecified, "LightingManager::InitiateAction(OFF_ACTION)");


This comment was generated by todo based on a TODO comment in a49971d in #4958. cc @jimlyall-q.

@todo
Copy link

todo bot commented Feb 22, 2021

Issue #3841

* TODO Issue #3841
* emberAfOnOffClusterInitCallback happens before the stack initialize the cluster
* attributes to the default value.
* The logic here expects something similar to the deprecated Plugins callback
* emberAfPluginOnOffClusterServerPostInitCallback.
*
*/
void emberAfOnOffClusterInitCallback(EndpointId endpoint)
{
GetAppTask().UpdateClusterState();
}


This comment was generated by todo based on a TODO comment in a49971d in #4958. cc @jimlyall-q.

@tima-q tima-q added the qpg QPG6xxx platform label Feb 23, 2021
@tima-q tima-q linked an issue Feb 23, 2021 that may be closed by this pull request
@mspang mspang merged commit 224cd32 into project-chip:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples qpg QPG6xxx platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QPG6100] Add Light application
6 participants