Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a mechanism to replace the "Plugins Callbacks" #3841

Closed
vivien-apple opened this issue Nov 16, 2020 · 1 comment
Closed

Provide a mechanism to replace the "Plugins Callbacks" #3841

vivien-apple opened this issue Nov 16, 2020 · 1 comment
Labels
Milestone

Comments

@vivien-apple
Copy link
Contributor

Problem

With #3464 all Plugins Callbacks are gone. But as it can be seen in #3782 some of them are already used in examples/.

While #3782 does not changed the behavior of the app with the current shape of the thee, it may introduce some issues once CHIP will support tokens or attributes initialisation to a specific value.

A mechanism equivalent to Plugins Callbacks needs to be introduced in CHIP in order to allow the use case of #3782

More generally, the provided mechanism should works across clusters to provide a global mechanism since the Plugins callbacks are likely fitting use cases from the field.

Proposed Solution

Implement a mechanism similar to Plugins Callbacks. It could be based on CHIPCallback.

One of the main difference with what was previously done with AppBuilder is that one could consider CHIP to have those "plugins" by default. AppBuilder uses to generate callbacks stubs and provide the method declarations from the gen/ folder. But in our case the "plugins" are permanent and it can be done differently.

@woody-apple
Copy link
Contributor

SW Dev Bug Review: Closing this, as doesn't appear needed anymore and/or is complete, please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants