Add a device selector view in CHIPTool iOS app #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang,
saurabhst,
shana-apple,
vivien-apple and
woody-apple
msandstedt
approved these changes
Feb 13, 2021
saurabhst
approved these changes
Feb 13, 2021
setting persistent storage delegate repeatedly is wasteful. This is being done here, and inhttps://github.com/project-chip/connectedhomeip/blob/4368420bc1f26bbfc3833a2bd34ea7c982c293bf/src/darwin/CHIPTool/CHIPTool/Framework Helpers/DefaultsUtils.m#L91-L101 This comment was generated by todo based on a
|
bzbarsky-apple
approved these changes
Feb 15, 2021
shana-apple
approved these changes
Feb 15, 2021
|
Changing the PR to draft, to prevent accidental merge. I think I can fix the TODO in this PR itself. |
bzbarsky-apple
approved these changes
Feb 15, 2021
andy31415
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIP Tool iOS app is missing a mechanism to select a device, if multiple devices have been paired with the controller. The current app can only communicate with the last paired device.
Summary of Changes
Added a device selector view to the app. This view will show a drop down list of paired devices. The user can select one of the available devices, and communicate with it.
This PR also integrates the selector view with Multi-admin view, and OnOff cluster view on iOS app.