add a TODO to remove repeated calls to set persistent storage delegate

project-chip · Feb 15, 2021 · 4368420 · 4368420
1 parent 1356a8d
commit 4368420
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/darwin/CHIPTool/CHIPTool/Framework Helpers/DefaultsUtils.m b/src/darwin/CHIPTool/CHIPTool/Framework Helpers/DefaultsUtils.m
@@ -88,6 +88,8 @@ void CHIPSetNextAvailableDeviceID(uint64_t id)
     dispatch_queue_t callbackQueue = dispatch_queue_create("com.chip.persistentstorage.callback", DISPATCH_QUEUE_SERIAL);
 
     CHIPDeviceController * controller = [CHIPDeviceController sharedController];
+    // TODO: setting persistent storage delegate repeatedly is wasteful. This is being done here, and in
+    //       GetPairedDevice() on every call. The delegate should be set once at the controller init time.
     [controller setPersistentStorageDelegate:storage queue:callbackQueue];
 
     NSError * error;