-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update our workflows to the new latest docker builds as well fix nRF builds #4657
Update our workflows to the new latest docker builds as well fix nRF builds #4657
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@andy31415 @jelderton @saurabhst @bzbarsky-apple Ready for review (Note, will be following up about the "latest" tag in: #3411) |
Size increase report for "esp32-example-build" from 26061f6
Full report output
|
One worry in using ':latest' is that it will couple docker releases with builds. Currently if I build on version A and need a breaking change to build with B (e.g. a SDK update that requires code changes for compatibility), currently I can have:
Throughout I would have no CI breakages because code specifies with what image it is compatible. If code uses ":latest" I am unsure how the label should be updated since as soon as I change the label, all code would use the updated image. @woody-apple - thoughts? Are the benefits of not needing to keep updating versions better than the downside of not being able to push incompatible SDK versions (and some non-reproducible builds, since checking out old commits may still use new SDKs) ? |
As mentioned above, this is temporary - I'm working on our proper docker CI, and this will at least keep our builds more up to date (some of the old workflows were vastly out of date). For the mean time, I'll keep an eye on docker images, and plan on getting our CI up either this week or weekend. I also have a pipeline I'm testing to rev all the version numbers in source when we push. |
I hate to pile on, but this is resolved here too: |
Merging due to hot-fix, due to broken build |
Problem
Our docker builds are... a few builds back, and when I went to update things - some stuff seems to not be working.
Summary of Changes
Help needed