Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup automated chip-build docker image builds #3411

Closed
gjc13 opened this issue Oct 23, 2020 · 5 comments
Closed

Setup automated chip-build docker image builds #3411

gjc13 opened this issue Oct 23, 2020 · 5 comments
Assignees

Comments

@gjc13
Copy link
Contributor

gjc13 commented Oct 23, 2020

Problem

Currently we need to ask authorized maintainers personally to upload thechip-build-xxx docker images.

Proposed Solution

Refer to https://docs.docker.com/docker-hub/builds/ to setup automated builds and tag latest.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.92. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@mspang
Copy link
Contributor

mspang commented Oct 25, 2020

We're running the build & tests on GitHub actions, not docker cloud. So building the images there is what I was thinking as it seems like a more natural fit. Maybe we could use

https://github.com/marketplace/actions/build-and-push-docker-images

I haven't looked at it in depth but I agree improving this process would help PRs that change docker images move along much more quickly.

@rwalker-apple @woody-apple

@andy31415
Copy link
Contributor

Existing setup works for now - not ideal, however due to support of versions, we are likely to sabilize build images. Will not build this as a bugfix for v1.

@woody-apple woody-apple removed this from the Next milestone Jul 6, 2022
@stale
Copy link

stale bot commented Jan 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jan 5, 2023
@stale
Copy link

stale bot commented Jan 14, 2023

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants