Add Silabs ZCL8 XML implementation #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add silabs implementation of af-gen-event and af-tokens. Not yet compatible with CHIP (TODO issue project-chip#3637)
jepenven-silabs
requested review from
mspang,
andy31415,
saurabhst,
BroderickCarlin,
bzbarsky-apple and
vivien-apple
pullapprove
bot
requested review from
chrisdecenzo,
hawk248,
jelderton,
wehale and
woody-apple
andy31415
approved these changes
Feb 2, 2021
woody-apple
approved these changes
Feb 2, 2021
saurabhst
approved these changes
Feb 3, 2021
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
* Add Silabs ZCL8 XML implementation - Add silabs implementation of af-gen-event and af-tokens. Not yet compatible with CHIP (TODO issue project-chip#3637) * Restyled by clang-format * Restyled by prettier-json * Restyled by prettier-markdown Co-authored-by: Restyled.io <[email protected]>
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
* Add Silabs ZCL8 XML implementation - Add silabs implementation of af-gen-event and af-tokens. Not yet compatible with CHIP (TODO issue project-chip#3637) * Restyled by clang-format * Restyled by prettier-json * Restyled by prettier-markdown Co-authored-by: Restyled.io <[email protected]>
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 4, 2021
* Add Silabs ZCL8 XML implementation - Add silabs implementation of af-gen-event and af-tokens. Not yet compatible with CHIP (TODO issue project-chip#3637) * Restyled by clang-format * Restyled by prettier-json * Restyled by prettier-markdown Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Software TT meeting of February 2 2021.
Problem
Data Model in XML format lives in the ZAP Github repo as a resource for unit-test. This make the data model unreliable since it could change at anytime.
Summary of Changes
Move the data model xml files in /src/app/zap-templates/zcl/data-model/silabs/. Goal is to remove the silabs subfolder once the CHIP data-model is implemented completely.
Also added the two missing templates. These templates are design to be use within Silabs Zigbee stack. No changes what so ever was made to the templates for CHIP use. These templates are provided as is to serve as a starting point for a CHIP implementation instead of starting from scratch.
Partial Fix of #3637