Add builds missing from "default" group in unified #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently enabling certain builds and running: ninja -C out/debug does not build them. This means we can end up building nothing at all, which is fairly confusing. They will however be built if you run either: ninja -C out/debug all ninja -C out/debug <specific target> Add the missing deps to the default target so that all opted in configs are built with the first command.
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
saurabhst and
woody-apple
saurabhst
approved these changes
Jan 29, 2021
andy31415
approved these changes
Feb 1, 2021
woody-apple
approved these changes
Feb 2, 2021
|
@mspang Build fails, assuming just a rebase is necessary? |
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
Currently enabling certain builds and running: ninja -C out/debug does not build them. This means we can end up building nothing at all, which is fairly confusing. They will however be built if you run either: ninja -C out/debug all ninja -C out/debug <specific target> Add the missing deps to the default target so that all opted in configs are built with the first command. Co-authored-by: Justin Wood <[email protected]>
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
Currently enabling certain builds and running: ninja -C out/debug does not build them. This means we can end up building nothing at all, which is fairly confusing. They will however be built if you run either: ninja -C out/debug all ninja -C out/debug <specific target> Add the missing deps to the default target so that all opted in configs are built with the first command. Co-authored-by: Justin Wood <[email protected]>
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 4, 2021
Currently enabling certain builds and running: ninja -C out/debug does not build them. This means we can end up building nothing at all, which is fairly confusing. They will however be built if you run either: ninja -C out/debug all ninja -C out/debug <specific target> Add the missing deps to the default target so that all opted in configs are built with the first command. Co-authored-by: Justin Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently enabling certain builds and running:
ninja -C out/debugdoes not build them. This means we can end up building nothing
at all, which is fairly confusing.
They will however be built if you run either:
ninja -C out/debug allninja -C out/debug <specific target>Add the missing deps to the default target so that all opted in configs
are built with the first command.