Skip to content

Commit

Permalink
Add builds missing from "default" group in unified (#4573)
Browse files Browse the repository at this point in the history
Currently enabling certain builds and running:

  ninja -C out/debug

does not build them. This means we can end up building nothing
at all, which is fairly confusing.

They will however be built if you run either:

  ninja -C out/debug all
  ninja -C out/debug <specific target>

Add the missing deps to the default target so that all opted in configs
are built with the first command.

Co-authored-by: Justin Wood <[email protected]>
  • Loading branch information
mspang and woody-apple authored Feb 3, 2021
1 parent fc9715e commit f8dc12e
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,18 @@ if (current_toolchain != "${dir_pw_toolchain}/dummy:dummy") {
if (enable_efr32_lock_app_build) {
deps += [ ":efr32_lock_app" ]
}
if (enable_efr32_lighting_app_build) {
deps += [ ":efr32_lighting_app" ]
}
if (enable_k32w_lock_app_build) {
deps += [ ":k32w_lock_app" ]
}
if (enable_qpg6100_lock_app_build) {
deps += [ ":qpg6100_lock_app" ]
}
if (enable_cc13x2_26x2_lock_app_build) {
deps += [ ":cc13x2_26x2_lock_app" ]
}
}

group("check") {
Expand Down

0 comments on commit f8dc12e

Please sign in to comment.