Add '#define EMBER_AF_PLUGIN_{{clusterName}}' and related to src/app/… #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
saurabhst
approved these changes
Nov 17, 2020
bzbarsky-apple
approved these changes
Nov 17, 2020
| /**** Cluster Plugins ****/ | ||
| {{#all_user_clusters}} | ||
|
|
||
| // Use this macro to check if {{side}} plugin {{name}} is included |
There was a problem hiding this comment.
Maybe "to check if the {{side}} side of the {{name}} cluster is included"? At some point we're going to want to change the "plugin" naming to something else, possibly....
There was a problem hiding this comment.
Maybe "to check if the {{side}} side of the {{name}} cluster is included"? At some point we're going to want to change the "plugin" naming to something else, possibly....
Done.
Also I have not bothered changing the name yet but I agree with you. Plugin does not makes sense in our context.
vivien-apple
force-pushed
the
ZAP_GenConfig
branch
from
e29415b to
0256c8e
Compare
vivien-apple
force-pushed
the
ZAP_GenConfig
branch
from
0256c8e to
a8f0fdc
Compare
…zap-templates/gen_config.h
andy31415
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zap-templates/gen_config.h
Problem
#3464 get rids of most of the
#definefromgen/gen_config.h. That's a nice cleanup but some of them are still required in order to build properly. Notably the one that are related toPlugins.I have not found a good way to define
EMBER_AF_PLUGIN_REPORTINGconditionaly. I have opened #3871 for it.Summary of Changes
EMBER_AF_PLUGIN_*macro generations tosrc/app/zap-templates/gen_config.zaptFixes #3627