Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionaly define EMBER_AF_PLUGIN_REPORTING #3871

Closed
vivien-apple opened this issue Nov 17, 2020 · 2 comments
Closed

Conditionaly define EMBER_AF_PLUGIN_REPORTING #3871

vivien-apple opened this issue Nov 17, 2020 · 2 comments

Comments

@vivien-apple
Copy link
Contributor

Problem

With the move to #3464, EMBER_AF_PLUGIN_REPORTING is enabled globally (see #3608)

It should be enable only if needed.

Proposed Solution

One possible solution would be to fix the templates helper and add an hasReportableAttributes method that will conditionally include this macro in gen_config.zapt

One other possible solution would be for the gen_config.zapt #define to be part of a global header that is generated at built-time. It may also enable the ability to automatically include the right dependencies for building depending on the set of choosen cluster.

@bzbarsky-apple
Copy link
Contributor

I believe in practice in CHIP all attributes are reportable, and all nodes have attributes that can change (e.g. in Basic), so reporting is always needed...

@woody-apple
Copy link
Contributor

Per @bzbarsky-apple 's comment above, closing, makes sense that reporting is always required. Please re-open if we're missing something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants