Remove 'emberAfClusterSecurityCustomCallback' from src/app

[vivien-apple]

Problem

#3809 list all the callbacks that are kept when migrating to ZAP in #3464. While some definitively makes senses, some others may be some dependencies that does not make sense.

One example of such callback is emberAfClusterSecurityCustomCallback since security is not optional in CHIP.

This patch has some intersection with #3462 but this is just because EmberAfProfileId is used in emberAfClusterSecurityCustomCallback

Summary of Changes

• Remove emberAfClusterSecurityCustomCallback callbacks from gen/
• Remove the only usage of emberAfClusterSecurityCustomCallback that was leading to a stub anyway
• Remove a bunch of some other security related code into src/app/util. My understanding is that the secure layer is on top of this code, so security features will not be managed by it.

[bzbarsky-apple]

Awesome cleanup!

[vivien-apple]

I just pushed an update to remove the methods from src/app/zap-templates since #3824 has just landed and it was adding the methods stubs just in case this one was not going to land.

[github-actions]

Size increase report for "nrfconnect-example-build" from 7bd7736

File	Section	File	VM
chip-lighting.elf	shell_root_cmds_sections	4	4
chip-lighting.elf	rodata	-88	-92
chip-lighting.elf	text	-324	-324
chip-lock.elf	rodata	-88	-88
chip-lock.elf	text	-320	-320

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
shell_root_cmds_sections,4,4
.debug_abbrev,0,-30
.debug_aranges,0,-40
rodata,-92,-88
.debug_ranges,0,-96
.symtab,0,-144
.debug_frame,0,-160
.strtab,0,-160
text,-324,-324
.debug_line,0,-488
.debug_loc,0,-601
.debug_str,0,-1223
.debug_info,0,-1402

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_abbrev,0,-30
.debug_aranges,0,-40
rodata,-88,-88
.debug_ranges,0,-96
.debug_frame,0,-144
.symtab,0,-144
.strtab,0,-160
text,-320,-320
.debug_line,0,-485
.debug_loc,0,-600
.debug_str,0,-1132
.debug_info,0,-1385

[github-actions]

Size increase report for "esp32-example-build" from 7bd7736

File	Section	File	VM
chip-all-clusters-app.elf	.flash.rodata	64	64
chip-all-clusters-app.elf	.flash.text	-260	-260

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.rodata,64,64
.xt.prop._ZN4chip8Encoding12LittleEndian7Write32ERPhj,0,1
.debug_abbrev,0,-30
.debug_aranges,0,-40
.symtab,0,-64
[Unmapped],0,-64
.debug_ranges,0,-88
.debug_frame,0,-144
.strtab,0,-160
.flash.text,-260,-260
.debug_loc,0,-543
.debug_line,0,-960
.debug_str,0,-1121
.debug_info,0,-1351