Add missing non-clusters related callbacks to src/app/zap-templates #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
|
For the record, this list has been hand-crafted by doing a rebase of #3464 on tip and trying to build it. |
|
Also for the record I used |
rwalker-apple
approved these changes
Nov 12, 2020
andy31415
approved these changes
Nov 12, 2020
bzbarsky-apple
approved these changes
Nov 12, 2020
vivien-apple
force-pushed
the
ZAP_AddMissingNonClustersRelatedCallbacks
branch
from
c1ec10e to
fcde5fa
Compare
vivien-apple
force-pushed
the
ZAP_AddMissingNonClustersRelatedCallbacks
branch
from
fcde5fa to
5a65711
Compare
jelderton
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#3464 is removing a large chunk of the callbacks stubs generated by
AppBuilder. As a results various places insrc/app/utilare commented out.Some of those callbacks are related to
Pluginsand in this case it makes sense that ZAP does not have informations about it and so can not generate them. I already have opened a bunch of PRs to fix that.Some others, are not-clusters related, and they should probably stays until we figured out what to do with them.
Summary of Changes