[ICD] Improve ICDClientStorage #36054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Time ICDs (project-chip#35956) (project-chip#35960) * Remove optional spec check * Add static_assert for the slow poll config for SIT ICDs * Add missing include * fix restyler error * fix spacing * Remove client build flag since it is not used
* Add missing feature map bit * Generation Co-authored-by: Andrei Litvin <[email protected]>
* Refactor Sensor and LCD code * Address review comments
…ect-chip#36028) * [Android] Add StayActive support during commission flow for LIT (project-chip#35959) * Fix crash when handling jStayActiveMsec (project-chip#35997)
…ip#36025) (project-chip#36031) * Attempt to fix ESP32 builds by not compiling insights at all. This breaks insights, but should make CI pass * Fix typo * Another better fix: pull in the other dependency too --------- Co-authored-by: Andrei Litvin <[email protected]>
* Improve ICDClientStorage -- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * address comments * Restyled by whitespace * Restyled by clang-format * address comments * address comments and add more tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]>
|
Review changes with SemanticDiff. Analyzed 2 of 43 files. File Information
|
github-actions
bot
added
documentation
|
|
|
PR #36054: Size comparison from bf37d4e to 286f03f Full report (93 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP #36036 to 1.4 branch, which has been merged to master