Attempt to fix ESP32 builds by adding an extra dependency #36025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaks insights, but should make CI pass
|
Review changes with SemanticDiff. |
andy31415
changed the title
|
PR #36025: Size comparison from 043ff67 to a4ca06d Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Oct 10, 2024
…ip#36025) * Attempt to fix ESP32 builds by not compiling insights at all. This breaks insights, but should make CI pass * Fix typo * Another better fix: pull in the other dependency too --------- Co-authored-by: Andrei Litvin <[email protected]>
andy31415
added a commit
that referenced
this pull request
Oct 10, 2024
…36031) * Attempt to fix ESP32 builds by not compiling insights at all. This breaks insights, but should make CI pass * Fix typo * Another better fix: pull in the other dependency too --------- Co-authored-by: Andrei Litvin <[email protected]>
dinabenamar
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 24, 2024
…ncy (project-chip#36025) (project-chip#36031) * Attempt to fix ESP32 builds by not compiling insights at all. This breaks insights, but should make CI pass * Fix typo * Another better fix: pull in the other dependency too --------- Co-authored-by: Andrei Litvin <[email protected]> (cherry picked from commit dd6f974)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Nov 14, 2024
… dependency (project-chip#36025) (project-chip#36031)" This reverts commit 69407b6. Signed-off-by: Gatien Chapon <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ip#36025) * Attempt to fix ESP32 builds by not compiling insights at all. This breaks insights, but should make CI pass * Fix typo * Another better fix: pull in the other dependency too --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI fails after espressif/esp-insights#47
It seems that insights 1.0.1 depends on a header in esp_diag_data_store that we did not fix the version for (and were pulling latest as a result). This gives a compile failure.