Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casts when determining endpoint indices. #36047

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix casts when determining endpoint indices. #36047

merged 1 commit into from
Oct 11, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

Not everything got updated correctly when endpoint indices changed from uint8 to uint16.

Fixes #36007

@bzbarsky-apple
Fix casts when determining endpoint indices.
cb234d9 
Not everything got updated correctly when endpoint indices changed from uint8 to
uint16.

Fixes project-chip#36007
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added the app label Oct 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

PR #36047: Size comparison from 7287041 to cb234d9

Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7287041 cb234d9 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349682 1349682 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647718 647718 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825204 825204 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053834 1053834 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974974 974974 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829492 829492 0 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814832 814832 0 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761396 761396 0 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745624 745624 0 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617154 617154 0 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657258 657258 0 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678477 678477 0 0.0
RAM 78668 78668 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698321 698321 0 0.0
RAM 81300 81300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698321 698321 0 0.0
RAM 81300 81300 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655257 655257 0 0.0
RAM 73736 73736 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614805 614805 0 0.0
RAM 71628 71628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634433 634433 0 0.0
RAM 74180 74180 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634433 634433 0 0.0
RAM 74180 74180 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634125 634125 0 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653833 653833 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653833 653833 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609429 609429 0 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629289 629289 0 0.0
RAM 71396 71396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629289 629289 0 0.0
RAM 71396 71396 0 0.0
efr32 lighting-app BRD4187C FLASH 934608 934608 0 0.0
RAM 136116 136116 0 0.0
lock-app BRD2605a FLASH 740704 740696 -8 -0.0
RAM 230976 230976 0 0.0
BRD4338a FLASH 741352 741344 -8 -0.0
RAM 231008 231008 0 0.0
window-app BRD4187C FLASH 1018140 1018140 0 0.0
RAM 128052 128052 0 0.0
esp32 all-clusters-app c3devkit DRAM 94248 94248 0 0.0
FLASH 1538700 1538700 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115192 115192 0 0.0
FLASH 1549010 1549010 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781021 2781021 0 0.0
RAM 129520 129520 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6085626 6085626 0 0.0
RAM 514752 514752 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5418300 5418300 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751772 4751760 -12 -0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12780298 12780298 0 0.0
RAM 567890 567890 0 0.0
chip-tool-ipv6only arm64 unknown 20880 20880 0 0.0
FLASH 11396576 11396576 0 0.0
RAM 618432 618432 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11091169 11091169 0 0.0
RAM 567578 567578 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4575402 4575394 -8 -0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5692353 5692353 0 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801336 4801336 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430760 4430760 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569574 4569574 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3111085 3111085 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319488 4319488 0 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6029685 6029669 -16 -0.0
RAM 588256 588256 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10979373 10979373 0 0.0
RAM 656960 656960 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914460 914460 0 0.0
RAM 142359 142359 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885276 885276 0 0.0
RAM 140498 140498 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847880 847880 0 0.0
RAM 141261 141261 0 0.0
nxp contact k32w0+release FLASH 582216 582216 0 0.0
RAM 70952 70952 0 0.0
k32w1+release FLASH 597048 597048 0 0.0
RAM 63176 63176 0 0.0
mcxw71+release FLASH 596808 596808 0 0.0
RAM 63176 63176 0 0.0
light k32w0+release FLASH 618732 618732 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 683040 683040 0 0.0
RAM 48808 48808 0 0.0
mcxw71+release FLASH 683040 683040 0 0.0
RAM 48808 48808 0 0.0
lock k32w1+release FLASH 705408 705408 0 0.0
RAM 67316 67316 0 0.0
mcxw71+release FLASH 705416 705416 0 0.0
RAM 67316 67316 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646340 1646340 0 0.0
RAM 211400 211400 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552388 1552388 0 0.0
RAM 208200 208200 0 0.0
light cy8ckit_062s2_43012 FLASH 1467860 1467860 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464932 1464932 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660528 660528 0 0.0
RAM 105396 105396 0 0.0
lock-app qpg6105+debug FLASH 618548 618548 0 0.0
RAM 99864 99864 0 0.0
stm32 light STM32WB5MM-DK FLASH 481824 481824 0 0.0
RAM 144844 144844 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620986 620986 0 0.0
RAM 50648 50648 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688188 688188 0 0.0
RAM 148488 148488 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 781180 781180 0 0.0
RAM 110440 110440 0 0.0
bridge-app tlsr9258a FLASH 681086 681086 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620750 620750 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708692 708692 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625692 625692 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811452 811452 0 0.0
RAM 99100 99100 0 0.0
lock-app-dfu tlsr9528a FLASH 656656 656656 0 0.0
RAM 66660 66660 0 0.0
ota-requestor-app tlsr9258a FLASH 697064 697064 0 0.0
RAM 90896 90896 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634384 634384 0 0.0
RAM 55476 55476 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611574 611574 0 0.0
RAM 52720 52720 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627900 627900 0 0.0
RAM 52320 52320 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653706 653706 0 0.0
RAM 56268 56268 0 0.0
thermostat tlsr9518adk80d FLASH 638306 638306 0 0.0
RAM 53112 53112 0 0.0
window-covering tlsr9118bdk40d FLASH 524444 524444 0 0.0
RAM 97444 97444 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1726772 1726772 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10528 10528 0 0.0
FLASH 17718602 17718602 0 0.0
RAM 7714800 7714800 0 0.0

@mergify mergify bot merged commit 48cf3e5 into project-chip:master Oct 11, 2024
70 checks passed
@bzbarsky-apple bzbarsky-apple deleted the fix-endpoint-index-casts branch October 11, 2024 20:28
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@bzbarsky-apple @yyzhong-g
Fix casts when determining endpoint indices. (project-chip#36047)
9b225de 
Not everything got updated correctly when endpoint indices changed from uint8 to
uint16.

Fixes project-chip#36007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] emberAfClearDynamicEndpoint() invalid real index cast (uint8_t instead of uint16_t)
3 participants
@bzbarsky-apple @andy31415 @yunhanw-google