[BUG] emberAfClearDynamicEndpoint() invalid real index cast (uint8_t instead of uint16_t)

[hacker-cb]

Reproduction steps

Current emberAfClearDynamicEndpoint() has error during calculation real index of dynamic endpoint. As a result, total endpoints index is limited to 255.

emberAfSetDynamicEndpoint() - ok, uint16_t.

connectedhomeip/src/app/util/attribute-storage.cpp

Line 285 in 8a01f93

index = static_cast<uint16_t>(realIndex);

emberAfClearDynamicEndpoint() - wrong, uint8_t.

connectedhomeip/src/app/util/attribute-storage.cpp

Line 325 in 8a01f93

index = static_cast<uint8_t>(index + FIXED_ENDPOINT_COUNT);

So, in emberAfClearDynamicEndpoint() should be cast to uint16_t

Updates:

emberAfGetDynamicIndexFromEndpoint - wrong, uint8_t.

connectedhomeip/src/app/util/attribute-storage.cpp

Line 258 in 8a01f93

return static_cast<uint8_t>(index - FIXED_ENDPOINT_COUNT);

Bug prevalence

Always

GitHub hash of the SDK that was being used

8a01f93

Platform

core

[bzbarsky-apple]

emberAfGetDynamicIndexFromEndpoint has a similar problem.

[hacker-cb]

I updated issue first message.