Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeviceSubscriptionManager to manage subscription of fabric-admin #35305

Merged
merged 21 commits into from
Aug 31, 2024
Merged

Add DeviceSubscriptionManager to manage subscription of fabric-admin #35305

merged 21 commits into from
Aug 31, 2024

Conversation

tehampson
Copy link
Contributor

@tehampson tehampson commented Aug 29, 2024 •
edited
Loading

This passes TC_MCORE_FS_1_5 from #35259

DeviceSubscriptionManager right now is a glorified pointer holder for DeviceSubscription. While we could have done this other ways this allows future flexibility in case we want to do something different with DeviceSubscription

Addressing cases where subscriptions may fail will be done in a follow up PR tracking issue is #35333

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

PR #35305: Size comparison from bab66f5 to 7f865fc

Full report (10 builds for nrfconnect, nxp, qpg, stm32, tizen)
platform target config section bab66f5 7f865fc change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 911048 911048 0 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 882772 882772 0 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 842316 842316 0 0.0
RAM 141038 141038 0 0.0
nxp contact k32w1+release FLASH 590416 590416 0 0.0
RAM 62488 62488 0 0.0
light k32w1+release FLASH 675104 675104 0 0.0
RAM 71472 71472 0 0.0
qpg lighting-app qpg6105+debug FLASH 656348 656348 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614208 614208 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478696 478696 0 0.0
RAM 144716 144716 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1712256 1712256 0 0.0
RAM 89380 89380 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508662 17510942 2280 0.0
RAM 7600300 7601220 920 0.0

@github-actions GitHub Actions
Copy link

PR #35305: Size comparison from bab66f5 to e4fa659

Full report (5 builds for nxp, stm32, tizen)
platform target config section bab66f5 e4fa659 change % change
nxp contact k32w1+release FLASH 590416 590416 0 0.0
RAM 62488 62488 0 0.0
light k32w1+release FLASH 675104 675104 0 0.0
RAM 71472 71472 0 0.0
stm32 light STM32WB5MM-DK FLASH 478696 478696 0 0.0
RAM 144716 144716 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1712256 1712256 0 0.0
RAM 89380 89380 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508662 17510942 2280 0.0
RAM 7600300 7601220 920 0.0

@tehampson tehampson enabled auto-merge (squash) August 30, 2024 21:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

PR #35305: Size comparison from bab66f5 to ed583fd

Full report (58 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
platform target config section bab66f5 ed583fd change % change
bl602 lighting-app bl602 FLASH 1279092 1279092 0 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1293202 1293202 0 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1318056 1318056 0 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944678 944678 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947078 947078 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039734 1039734 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 647494 647494 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894908 894908 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961082 961082 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963704 963704 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672761 672761 0 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692621 692621 0 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692621 692621 0 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649549 649549 0 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611193 611193 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630821 630821 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630821 630821 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 629233 629233 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648941 648941 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648941 648941 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603501 603501 0 0.0
RAM 68348 68348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623361 623361 0 0.0
RAM 70980 70980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623361 623361 0 0.0
RAM 70980 70980 0 0.0
efr32 lighting-app BRD4187C FLASH 930820 930844 24 0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740852 740988 136 0.0
RAM 209516 209516 0 0.0
window-app BRD4187C FLASH 1015904 1015928 24 0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94200 94200 0 0.0
FLASH 1535006 1535006 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115136 115136 0 0.0
FLASH 1544966 1544966 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2763705 2763653 -52 -0.0
RAM 128536 128536 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6056410 6056792 382 0.0
RAM 510328 510328 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5386678 5386658 -20 -0.0
RAM 240248 240248 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4731800 4732238 438 0.0
RAM 216952 217368 416 0.2
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12649906 12650904 998 0.0
RAM 558354 558354 0 0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10929653 10949549 19896 0.2
RAM 556602 557066 464 0.1
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4554580 4555346 766 0.0
RAM 203984 203984 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5668049 5668017 -32 -0.0
RAM 228056 228056 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4787114 4787062 -52 -0.0
RAM 203768 203768 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4426652 4426600 -52 -0.0
RAM 197752 197752 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4565206 4565186 -20 -0.0
RAM 202288 202288 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3088189 3088141 -48 -0.0
RAM 159040 159040 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6011605 6011589 -16 -0.0
RAM 583192 583192 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10854733 10854941 208 0.0
RAM 645768 645768 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 911048 911048 0 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 882772 882772 0 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 842316 842316 0 0.0
RAM 141038 141038 0 0.0
nxp contact k32w0+release FLASH 577796 577796 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590416 590416 0 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613224 613224 0 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 675104 675104 0 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642156 1642156 0 0.0
RAM 210920 210920 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1545972 1545972 0 0.0
RAM 207632 207632 0 0.0
light cy8ckit_062s2_43012 FLASH 1464764 1464764 0 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463652 1463652 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656348 656348 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614208 614208 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478696 478696 0 0.0
RAM 144716 144716 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1712256 1712256 0 0.0
RAM 89380 89380 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17508662 17510942 2280 0.0
RAM 7600300 7601220 920 0.0

@tehampson tehampson merged commit efa78b9 into project-chip:master Aug 31, 2024
65 of 67 checks passed
@tehampson tehampson mentioned this pull request Sep 2, 2024
Merged
@tehampson tehampson mentioned this pull request Sep 9, 2024
Closed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Sep 10, 2024
@tehampson @restyled-commits
@andy31415 @saurabhst @shgutte
Add DeviceSubscriptionManager to manage subscription of fabric-admin (p…
7ada478 
…roject-chip#35305)

---------

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: saurabhst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tehampson @andy31415 @saurabhst @yufengwangca @restyled-commits