Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cluster revision of the thermostat cluster to 7 (including… #34890

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Update the cluster revision of the thermostat cluster to 7 (including… #34890

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce5d2e3
Update the cluster revision of the thermostat cluster to 7 (including…
nivi-apple Aug 8, 2024
32aaf52
Fix the PICS condition for reading Presets and schedules attribute
nivi-apple Aug 8, 2024
afce336
Add PICS code for schedules feature to PICS.yaml
nivi-apple Aug 8, 2024
25c10af
Update the PICs code for atomic request from TSTAT.S.CFE.Rsp to TSTAT…
nivi-apple Aug 8, 2024
a8c3e5b
Merge branch 'master' into match_presets_sdk_code_to_test_plan
woody-apple Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9068,7 +9068,7 @@ endpoint 1 {
callback attribute eventList;
callback attribute attributeList;
ram attribute featureMap default = 0x0123;
ram attribute clusterRevision default = 6;
ram attribute clusterRevision default = 7;

handle command SetpointRaiseLower;
handle command SetActiveScheduleRequest;
Expand Down
2 changes: 1 addition & 1 deletion examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16918,7 +16918,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "6",
"defaultValue": "7",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
Expand Down
2 changes: 1 addition & 1 deletion examples/thermostat/thermostat-common/thermostat.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,7 +2801,7 @@ endpoint 1 {
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap default = 0x123;
ram attribute clusterRevision default = 6;
ram attribute clusterRevision default = 7;

handle command SetpointRaiseLower;
handle command SetActiveScheduleRequest;
Expand Down
2 changes: 1 addition & 1 deletion examples/thermostat/thermostat-common/thermostat.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5088,7 +5088,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "6",
"defaultValue": "7",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
Expand Down
2 changes: 1 addition & 1 deletion src/app/tests/suites/certification/Test_TC_TSTAT_1_1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ tests:
command: "readAttribute"
attribute: "ClusterRevision"
response:
value: 6
value: 7
constraints:
type: int16u

Expand Down
10 changes: 5 additions & 5 deletions src/app/tests/suites/certification/Test_TC_TSTAT_4_1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,39 +70,39 @@ tests:
saveAs: SchedulesValue

- label: "Step 2: TH reads the PresetTypes attribute from the DUT"
PICS: TSTAT.S.F08 & TSTAT.S.A0048
PICS: TSTAT.S.F08 && TSTAT.S.A0048
command: "readAttribute"
attribute: "PresetTypes"
response:
constraints:
type: list

- label: "Step 3: TH reads the NumberOfPresets attribute from the DUT"
PICS: TSTAT.S.F08 & TSTAT.S.A004a
PICS: TSTAT.S.F08 && TSTAT.S.A004a
command: "readAttribute"
attribute: "NumberOfPresets"
response:
constraints:
type: int8u

- label: "Step 4: TH reads the ActivePresetHandle attribute from the DUT"
PICS: TSTAT.S.F08 & TSTAT.S.A004e
PICS: TSTAT.S.F08 && TSTAT.S.A004e
command: "readAttribute"
attribute: "ActivePresetHandle"
response:
constraints:
type: octstr

- label: "Step 5: TH reads the Presets attribute from the DUT"
PICS: TSTAT.S.F08 & TSTAT.S.A0050
PICS: TSTAT.S.F08 && TSTAT.S.A0050
command: "readAttribute"
attribute: "Presets"
response:
constraints:
type: list

- label: "Step 6: TH reads the Schedules attribute from the DUT"
PICS: TSTAT.S.F07 & TSTAT.S.A0051
PICS: TSTAT.S.F07 && TSTAT.S.A0051
command: "readAttribute"
attribute: "Schedules"
response:
Expand Down
3 changes: 2 additions & 1 deletion src/app/tests/suites/certification/ci-pics-values
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1931,6 +1931,7 @@ TSTAT.S.F03=0
TSTAT.S.F04=0
TSTAT.S.F05=1
TSTAT.S.F06=0
TSTAT.S.F07=0
TSTAT.S.F08=1

TSTAT.S.A0000=1
Expand Down Expand Up @@ -1987,7 +1988,7 @@ TSTAT.S.A0048=1
TSTAT.S.A004a=1
TSTAT.S.A004e=1
TSTAT.S.A0050=1
TSTAT.S.A0051=1
TSTAT.S.A0051=0

TSTAT.S.M.MinSetpointDeadBandWritable=1
TSTAT.S.M.HVACSystemTypeConfigurationWritable=0
Expand Down
Loading