Update the cluster revision of the thermostat cluster to 7 (including… #34890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Presets feature) - Update the YAML file accordingly
|
Review changes with SemanticDiff. Analyzed 1 of 9 files.
|
github-actions
bot
added
examples
app
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
hasty
approved these changes
Aug 8, 2024
|
PR #34890: Size comparison from 5044317 to ce5d2e3 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Disable the PICS code for Schedules feature and attribute since it is not implemented yet.
nivi-apple
force-pushed
the
match_presets_sdk_code_to_test_plan
branch
from
c13ddcb to
32aaf52
Compare
|
PR #34890: Size comparison from 95ff33b to 32aaf52 Full report (15 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
woody-apple
approved these changes
Aug 8, 2024
|
PR #34890: Size comparison from 95ff33b to afce336 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
….S.Cfe.Rsp to follow convention
|
PR #34890: Size comparison from 95ff33b to 25c10af Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Aug 9, 2024
|
Force merging per CSG request |
|
PR #34890: Size comparison from c0b140b to a8c3e5b Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
project-chip#34890) * Update the cluster revision of the thermostat cluster to 7 (including Presets feature) - Update the YAML file accordingly * Fix the PICS condition for reading Presets and schedules attribute - Disable the PICS code for Schedules feature and attribute since it is not implemented yet. * Add PICS code for schedules feature to PICS.yaml * Update the PICs code for atomic request from TSTAT.S.CFE.Rsp to TSTAT.S.Cfe.Rsp to follow convention --------- Co-authored-by: Justin Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Presets feature)
Fixes: #34889