Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] apply changes from PR #34797 to to concrete class #34856

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[Darwin] apply changes from PR #34797 to to concrete class #34856

merged 1 commit into from
Aug 7, 2024

Conversation

kiel-apple
Copy link
Contributor

since PR was opened before MTRDevice duplication PR landed

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added the darwin label Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

PR #34856: Size comparison from e0a765b to 08d8c5f

Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e0a765b 08d8c5f change % change
bl602 lighting-app bl602 FLASH 1278102 1278102 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292360 1292360 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317062 1317062 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1099242 1099242 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109936 1109936 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189308 1189308 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 882276 882276 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135446 1135446 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086404 1086404 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097410 1097410 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802832 802832 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818636 818636 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810968 810968 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763220 763220 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747728 747728 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612238 612238 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654750 654750 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671945 671945 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691797 691797 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691797 691797 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648741 648741 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610385 610385 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630021 630021 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630021 630021 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627833 627833 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647549 647549 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647549 647549 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601093 601093 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 620953 620953 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 620953 620953 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929896 929888 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737084 737076 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015476 1015476 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1532136 1532136 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542266 1542266 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2752139 2752139 0 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6032062 6032062 0 0.0
RAM 510128 510128 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5373052 5373052 0 0.0
RAM 239936 239936 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4727238 4727238 0 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12490026 12490026 0 0.0
RAM 557914 557914 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11169596 11169596 0 0.0
RAM 607920 607920 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11472803 11472803 0 0.0
RAM 554650 554650 0 0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4515908 4515908 0 0.0
RAM 202648 202648 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5661777 5661777 0 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4781774 4781774 0 0.0
RAM 203776 203776 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4422086 4422086 0 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4560696 4560696 0 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3073885 3073885 0 0.0
RAM 159048 159048 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4360436 4360436 0 0.0
RAM 242232 242232 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 6005173 6005173 0 0.0
RAM 583584 583584 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10693725 10693725 0 0.0
RAM 645064 645064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908224 908224 0 0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880332 880332 0 0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839876 839876 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 577068 577068 0 0.0
RAM 70472 70472 0 0.0
k32w1+release FLASH 592384 592384 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612528 612528 0 0.0
RAM 69944 69944 0 0.0
k32w1+release FLASH 677360 677360 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637476 1637476 0 0.0
RAM 210928 210928 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1542908 1542908 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463492 1463492 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462124 1462124 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612920 612920 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477960 477960 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619736 619736 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 679796 679796 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 772852 772852 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678440 678440 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621328 621328 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707192 707192 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620246 620246 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806332 806332 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654184 654184 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696472 696472 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630774 630774 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608284 608284 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628096 628096 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652106 652106 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 633086 633086 0 0.0
RAM 53380 53380 0 0.0
window-covering tlsr9118bdk40d FLASH 522246 522246 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 4796 4796 0 0.0
FLASH 1695372 1695372 0 0.0
RAM 89176 89176 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17324526 17324526 0 0.0
RAM 7565032 7565032 0 0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Aug 7, 2024
Merged
@kiel-apple kiel-apple merged commit 968a0e6 into project-chip:master Aug 7, 2024
68 checks passed
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Aug 12, 2024
@kiel-apple @austina-csa
apply changes from PR project-chip#34797 to to concrete class (projec…
ea0cd59 
…t-chip#34856)
@kiel-apple kiel-apple deleted the mtrdevice-concrete-update branch September 5, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiel-apple @woody-apple @bzbarsky-apple @jtung-apple