[Darwin] MTRDevice subscription estalished handler should change state before async #34797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #34797: Size comparison from 653a55f to 413b47b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
reviewed
Aug 6, 2024
kiel-apple
approved these changes
Aug 6, 2024
bzbarsky-apple
approved these changes
Aug 6, 2024
Co-authored-by: Kiel Oleson <[email protected]>
|
PR #34797: Size comparison from 653a55f to 9fb264a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
if #34813 lands before this, please duplicate the change in |
kiel-apple
added a commit
to kiel-apple/connectedhomeip
that referenced
this pull request
Aug 7, 2024
kiel-apple
added a commit
that referenced
this pull request
Aug 7, 2024
woody-apple
pushed a commit
that referenced
this pull request
Aug 8, 2024
* apply changes from PR #34797 to to concrete class * Improve description for MTRDevice. Includes various information that wasn't included before but probably should be. * Address review comments. --------- Co-authored-by: Kiel Oleson <[email protected]>
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
* apply changes from PR project-chip#34797 to to concrete class * Improve description for MTRDevice. Includes various information that wasn't included before but probably should be. * Address review comments. --------- Co-authored-by: Kiel Oleson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-[MTRPerControllerStorageTests testMTRDeviceResetSubscription]test in Darwin tests has been flaky, due to the new subscription reset mechanism introducing a race between read client callback and MTRDevice internal state changes.This patch fixes the specific unit test failure. For the general cases, I've filed: #34796