Add test scripts for testing Presets attributes and commands for Thermostat cluster #34614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
woody-apple
approved these changes
Jul 30, 2024
|
PR #34614: Size comparison from 08dfc13 to 57e36cb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
force-pushed
the
add_test_scripts_for_presets
branch
from
57e36cb to
3ef31e0
Compare
|
PR #34614: Size comparison from 8060d45 to 3ef31e0 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
nivi-apple
force-pushed
the
add_test_scripts_for_presets
branch
from
3ef31e0 to
921d60c
Compare
|
PR #34614: Size comparison from 29b055a to 921d60c Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
nivi-apple
force-pushed
the
add_test_scripts_for_presets
branch
from
921d60c to
bc6fe84
Compare
|
PR #34614: Size comparison from 29b055a to bc6fe84 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 30, 2024
nivi-apple
force-pushed
the
add_test_scripts_for_presets
branch
from
bc6fe84 to
1fa5d26
Compare
|
PR #34614: Size comparison from 268e7ca to 1fa5d26 Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34614: Size comparison from 268e7ca to 6c3ce8b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
arkq,
axelnxp,
bauerschwan,
chapongatien,
chrisdecenzo,
chshu and
chulspro
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
wiba-nordic and
younghak-hwang
|
PR #34614: Size comparison from 268e7ca to b6af1d6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
force-pushed
the
add_test_scripts_for_presets
branch
from
0812501 to
9d796dd
Compare
nivi-apple
force-pushed
the
add_test_scripts_for_presets
branch
from
9d796dd to
6d2f9f8
Compare
|
PR #34614: Size comparison from b426fde to 50fb5cc Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34614: Size comparison from b426fde to fcb85a5 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34614: Size comparison from b426fde to 6c6908d Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 31, 2024
| "Step 2: Test Harness writes to the Presets attribute without calling | ||
| the StartPresetsSchedulesEditRequest" | ||
| PICS: TSTAT.S.F08 && TSTAT.S.A0050 | ||
| verification: | |
There was a problem hiding this comment.
I did not realize these were manual steps.
We have a requirement today that no new manual tests are acceptable to be checked in. @nivi-apple @woody-apple please revert this file from this PR as a followup PR. we can keep the non-manual tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34613