-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HVAC] Use atomic writes with Presets #34570
Conversation
…ster Clean up the Thermostat cluster and remove the TemperatureSetpointHoldPolicy attribute and SetTemperatureSetpointHoldPolicy command
Editorial fixes
Co-authored-by: Boris Zbarsky <[email protected]>
# Conflicts: # src/app/zap-templates/zcl/data-model/chip/global-structs.xml
# Conflicts: # src/app/zap-templates/zcl/data-model/chip/global-structs.xml # src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml
Review changes with SemanticDiff. Analyzed 10 of 162 files. Overall, the semantic diff is 11% smaller than the GitHub diff. File Information
|
PR #34570: Size comparison from 13fe13a to 72d114f Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
# Conflicts: # src/controller/python/chip/clusters/Objects.py
Specific changes: * Enable SetActivePresetRequest command in all-clusters-app. * Fix assignment of a PresetStructWithOwnedMembers to another PresetStructWithOwnedMembers to actually work correctly. * Move constraint checks that happen on write from commit to write. * Fix sending of atomic responses to not have use-stack-after-return. * Fix PICS for the tests involved.
Fix tests to work with the new setup.
… add_presets_to_Sdk # Conflicts: # examples/air-purifier-app/air-purifier-common/air-purifier-app.matter # examples/air-quality-sensor-app/air-quality-sensor-common/air-quality-sensor-app.matter # examples/all-clusters-app/all-clusters-common/all-clusters-app.matter # examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter # examples/bridge-app/bridge-common/bridge-app.matter # examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter # examples/chef/devices/rootnode_airpurifier_73a6fe2651.matter # examples/chef/devices/rootnode_airpurifier_airqualitysensor_temperaturesensor_humiditysensor_thermostat_56de3d5f45.matter # examples/chef/devices/rootnode_airqualitysensor_e63187f6c9.matter # examples/chef/devices/rootnode_basicvideoplayer_0ff86e943b.matter # examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter # examples/chef/devices/rootnode_contactsensor_27f76aeaf5.matter # examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.matter # examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter # examples/chef/devices/rootnode_dimmablepluginunit_f8a9a0b9d4.matter # examples/chef/devices/rootnode_dishwasher_cc105034fe.matter # examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter # examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.matter # examples/chef/devices/rootnode_fan_7N2TobIlOX.matter # examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.matter # examples/chef/devices/rootnode_genericswitch_2dfff6e516.matter # examples/chef/devices/rootnode_genericswitch_9866e35d0b.matter # examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter # examples/chef/devices/rootnode_humiditysensor_Xyj4gda6Hb.matter # examples/chef/devices/rootnode_laundrywasher_fb10d238c8.matter # examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.matter # examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.matter # examples/chef/devices/rootnode_onofflight_bbs1b7IaOV.matter # examples/chef/devices/rootnode_onofflight_samplemei.matter # examples/chef/devices/rootnode_onofflightswitch_FsPlMr090Q.matter # examples/chef/devices/rootnode_onoffpluginunit_Wtf8ss5EBY.matter # examples/chef/devices/rootnode_pressuresensor_s0qC9wLH4k.matter # examples/chef/devices/rootnode_pump_5f904818cc.matter # examples/chef/devices/rootnode_pump_a811bb33a0.matter # examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter # examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter # examples/chef/devices/rootnode_roomairconditioner_9cf3607804.matter # examples/chef/devices/rootnode_smokecoalarm_686fe0dcb8.matter # examples/chef/devices/rootnode_speaker_RpzeXdimqA.matter # examples/chef/devices/rootnode_temperaturesensor_Qy1zkNW7c3.matter # examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter # examples/chef/devices/rootnode_windowcovering_RLCxaGi9Yx.matter # examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.matter # examples/contact-sensor-app/nxp/zap-lit/contact-sensor-app.matter # examples/contact-sensor-app/nxp/zap-sit/contact-sensor-app.matter # examples/dishwasher-app/dishwasher-common/dishwasher-app.matter # examples/energy-management-app/energy-management-common/energy-management-app.matter # examples/fabric-bridge-app/fabric-bridge-common/fabric-bridge-app.matter # examples/laundry-washer-app/nxp/zap/laundry-washer-app.matter # examples/light-switch-app/light-switch-common/light-switch-app.matter # examples/light-switch-app/qpg/zap/switch.matter # examples/lighting-app/bouffalolab/data_model/lighting-app-ethernet.matter # examples/lighting-app/bouffalolab/data_model/lighting-app-thread.matter # examples/lighting-app/bouffalolab/data_model/lighting-app-wifi.matter # examples/lighting-app/lighting-common/lighting-app.matter # examples/lighting-app/nxp/zap/lighting-on-off.matter # examples/lighting-app/qpg/zap/light.matter # examples/lighting-app/silabs/data_model/lighting-thread-app.matter # examples/lighting-app/silabs/data_model/lighting-wifi-app.matter # examples/lit-icd-app/lit-icd-common/lit-icd-server-app.matter # examples/lock-app/lock-common/lock-app.matter # examples/lock-app/nxp/zap/lock-app.matter # examples/lock-app/qpg/zap/lock.matter # examples/log-source-app/log-source-common/log-source-app.matter # examples/microwave-oven-app/microwave-oven-common/microwave-oven-app.matter # examples/network-manager-app/network-manager-common/network-manager-app.matter # examples/ota-provider-app/ota-provider-common/ota-provider-app.matter # examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter # examples/placeholder/linux/apps/app1/config.matter # examples/placeholder/linux/apps/app2/config.matter # examples/pump-app/pump-common/pump-app.matter # examples/pump-app/silabs/data_model/pump-thread-app.matter # examples/pump-app/silabs/data_model/pump-wifi-app.matter # examples/pump-controller-app/pump-controller-common/pump-controller-app.matter # examples/refrigerator-app/refrigerator-common/refrigerator-app.matter # examples/rvc-app/rvc-common/rvc-app.matter # examples/smoke-co-alarm-app/smoke-co-alarm-common/smoke-co-alarm-app.matter # examples/temperature-measurement-app/temperature-measurement-common/temperature-measurement.matter # examples/thermostat/nxp/zap/thermostat_matter_thread.matter # examples/thermostat/nxp/zap/thermostat_matter_wifi.matter # examples/thermostat/qpg/zap/thermostaticRadiatorValve.matter # examples/thermostat/thermostat-common/thermostat.matter # examples/tv-app/tv-common/tv-app.matter # examples/tv-casting-app/tv-casting-common/tv-casting-app.matter # examples/virtual-device-app/virtual-device-common/virtual-device-app.matter # examples/window-app/common/window-app.matter # src/controller/data_model/controller-clusters.matter # src/controller/python/chip/clusters/Objects.py # src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h # src/darwin/Framework/CHIP/zap-generated/MTRStructsObjc.h # src/darwin/Framework/CHIP/zap-generated/MTRStructsObjc.mm # zzz_generated/app-common/app-common/zap-generated/cluster-enums-check.h # zzz_generated/app-common/app-common/zap-generated/cluster-enums.h # zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp # zzz_generated/app-common/app-common/zap-generated/cluster-objects.h
PR #34570: Size comparison from bbef51a to 0966a01 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34570: Size comparison from bbef51a to c37228c Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34570: Size comparison from bbef51a to 18d202a Increases above 0.2%:
Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
PR #34570: Size comparison from bbef51a to 18325f4 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34570: Size comparison from bbef51a to 11eda5a Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… into add_presets_to_Sdk
PR #34570: Size comparison from bbef51a to 9a4d415 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This converts the presets implementation in #34532 to use atomic writes.