Add ARL feature to access control cluster and regen #34535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edits to src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml then zap_regen_all.py
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml
Outdated
Show resolved
Hide resolved
|
PR #34535: Size comparison from 4334e91 to a899722 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml
Outdated
Show resolved
Hide resolved
|
PR #34535: Size comparison from 4334e91 to 51d75ee Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 26, 2024
|
PR #34535: Size comparison from 5e3127f to 0e0609d Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34535: Size comparison from a98234f to d1f83af Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
previously approved these changes
Jul 29, 2024
andy31415
dismissed
their stale review
Dismissing until some further spec vs PR alginments
|
PR #34535: Size comparison from a98234f to d18b03f Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
minor hand edits required to zap_regen_all.py successfully.
|
PR #34535: Size comparison from a98234f to 3754253 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
hawk248
approved these changes
Jul 29, 2024
hawk248
approved these changes
Jul 29, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add ARL feature to access control cluster and regen Edits to src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml then zap_regen_all.py * Fixed kotlin generation * Fixed response for ReviewFabricRestrictions command * review updates * Fix Python ZAP codegen mis-merge. * Updated acces-control-cluster.xml with alchemy minor hand edits required to zap_regen_all.py successfully. --------- Co-authored-by: Boris Zbarsky <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add ARL feature to access control cluster and regen Edits to src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml then zap_regen_all.py * Fixed kotlin generation * Fixed response for ReviewFabricRestrictions command * review updates * Fix Python ZAP codegen mis-merge. * Updated acces-control-cluster.xml with alchemy minor hand edits required to zap_regen_all.py successfully. --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits to src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml then zap_regen_all.py
The spec changes driving this PR is: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10010
(in-progress "hrap-1")