Add WHM to the all clusters app #34456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34456: Size comparison from 66847c6 to 03e95d4 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34456: Size comparison from 66847c6 to 39275f3 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jamesharrow
reviewed
Jul 23, 2024
examples/all-clusters-app/all-clusters-common/include/WhmDelegate.h
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/include/WhmDelegate.h
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/include/WhmDelegate.h
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/include/WhmDelegate.h
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/include/WhmDelegate.h
Outdated
Show resolved
Hide resolved
src/app/clusters/water-heater-management-server/water-heater-management-server.h
Outdated
Show resolved
Hide resolved
|
PR #34456: Size comparison from c88d5cf to bb44cf2 Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, mbed, nxp, qpg, stm32)
|
|
PR #34456: Size comparison from c88d5cf to 871ee38 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
|
PR #34456: Size comparison from 1b1340f to 13bfff9 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34456: Size comparison from c91a779 to b017a85 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34456: Size comparison from c91a779 to 58fcfa7 Increases above 0.2%:
Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34456: Size comparison from c91a779 to 8e94baa Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Andrei Litvin <[email protected]>
project-chip#34488) * Implemented the Quiete reporting quality logic for the CurrentLevel and RemainingTime attributes * Restyled by clang-format * use c++ struct rather than c struct format * add cluster-building-blocks to the data model public dep --------- Co-authored-by: Restyled.io <[email protected]>
* Revert "update tests and thermostat server cluster for new constraints for LocalTemperatureCalibration and MinSetpointDeadBand (project-chip#34474)" This reverts commit 335ac96. * Revert "update constraints for LocalTemperatureCalibration and MinSetpointDeadBand attributes (project-chip#34473)" This reverts commit 21a5bd6.
|
PR #34456: Size comparison from 44c725d to 5964de9 Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34456: Size comparison from 44c725d to c13aca1 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 28, 2024
examples/all-clusters-app/all-clusters-common/src/WhmDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
18 tasks
…mpl.cpp Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #34456: Size comparison from 44c725d to 713fad0 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
doru91
approved these changes
Jul 29, 2024
…rer.cpp Co-authored-by: Boris Zbarsky <[email protected]>
…rer.cpp Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #34456: Size comparison from 5e3127f to a7f74bd Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
approved these changes
Jul 29, 2024
examples/all-clusters-app/all-clusters-common/src/WhmDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/src/WhmDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
|
PR #34456: Size comparison from f8d8c22 to 15fed34 Increases above 0.2%:
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, mbed, nrfconnect, nxp, qpg, stm32, telink, tizen)
|
…mpl.cpp Co-authored-by: lpbeliveau-silabs <[email protected]>
|
PR #34456: Size comparison from f8d8c22 to 47d0f32 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add WHM to the all clusters app * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Fix CI test * Address review comments from JamesH * Address review comments from JamesH * Address review comments from JamesH * Restyled by clang-format * Get tests passing again * Restyled by clang-format * Declare some global items for future testing (project-chip#34509) Co-authored-by: Andrei Litvin <[email protected]> * [LevelControl] Implemented the Q quality logic for the CurrentLevel a… (project-chip#34488) * Implemented the Quiete reporting quality logic for the CurrentLevel and RemainingTime attributes * Restyled by clang-format * use c++ struct rather than c struct format * add cluster-building-blocks to the data model public dep --------- Co-authored-by: Restyled.io <[email protected]> * Revert thermostat stuff breaking tot (project-chip#34518) * Revert "update tests and thermostat server cluster for new constraints for LocalTemperatureCalibration and MinSetpointDeadBand (project-chip#34474)" This reverts commit 335ac96. * Revert "update constraints for LocalTemperatureCalibration and MinSetpointDeadBand attributes (project-chip#34473)" This reverts commit 21a5bd6. * [Telink] Update Docker image (Zephyr update) (project-chip#34503) * Add TransportPayloadCapability flag for GetConnectedDevices and bubble (project-chip#34450) up the flag to the wrapper IM Python APIs. Add python script binding methods for LargePayload tests --to check if session allows large payload. --to close the underlying TCP connection. --to check if the session is active. * Remove no-longer-used MTRDevice logic for truncating data version lists (project-chip#34183) * Remove no-longer-used MTRDevice logic for truncating data version lists After project-chip#34111, ReadClient handles this logic itself, so the attempted truncation in MTRDevice was now dead code. * Address review comment. * Fix compile issues. * Address another review comment. * Address review comment. * Address review comments by JamesH * Remove unnecessary include file * Address further review comments from JamhesH * Restyled by whitespace * Restyled by clang-format * Address further review comments from JamesH * Address further review comments from JamesH * Update examples/all-clusters-app/all-clusters-common/src/WhmDelegateImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/all-clusters-app/all-clusters-common/src/WhmManufacturer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/all-clusters-app/all-clusters-common/src/WhmManufacturer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Undo suggested change from Boris as idx needed in the loop * Update examples/all-clusters-app/all-clusters-common/src/WhmDelegateImpl.cpp Co-authored-by: lpbeliveau-silabs <[email protected]> * Address review comments --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Junior Martinez <[email protected]> Co-authored-by: C Freeman <[email protected]> Co-authored-by: Alex Tsitsiura <[email protected]> Co-authored-by: Pradip De <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: jamesharrow <[email protected]> Co-authored-by: lpbeliveau-silabs <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add WHM to the all clusters app * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Fix CI test * Address review comments from JamesH * Address review comments from JamesH * Address review comments from JamesH * Restyled by clang-format * Get tests passing again * Restyled by clang-format * Declare some global items for future testing (project-chip#34509) Co-authored-by: Andrei Litvin <[email protected]> * [LevelControl] Implemented the Q quality logic for the CurrentLevel a… (project-chip#34488) * Implemented the Quiete reporting quality logic for the CurrentLevel and RemainingTime attributes * Restyled by clang-format * use c++ struct rather than c struct format * add cluster-building-blocks to the data model public dep --------- Co-authored-by: Restyled.io <[email protected]> * Revert thermostat stuff breaking tot (project-chip#34518) * Revert "update tests and thermostat server cluster for new constraints for LocalTemperatureCalibration and MinSetpointDeadBand (project-chip#34474)" This reverts commit 335ac96. * Revert "update constraints for LocalTemperatureCalibration and MinSetpointDeadBand attributes (project-chip#34473)" This reverts commit 21a5bd6. * [Telink] Update Docker image (Zephyr update) (project-chip#34503) * Add TransportPayloadCapability flag for GetConnectedDevices and bubble (project-chip#34450) up the flag to the wrapper IM Python APIs. Add python script binding methods for LargePayload tests --to check if session allows large payload. --to close the underlying TCP connection. --to check if the session is active. * Remove no-longer-used MTRDevice logic for truncating data version lists (project-chip#34183) * Remove no-longer-used MTRDevice logic for truncating data version lists After project-chip#34111, ReadClient handles this logic itself, so the attempted truncation in MTRDevice was now dead code. * Address review comment. * Fix compile issues. * Address another review comment. * Address review comment. * Address review comments by JamesH * Remove unnecessary include file * Address further review comments from JamhesH * Restyled by whitespace * Restyled by clang-format * Address further review comments from JamesH * Address further review comments from JamesH * Update examples/all-clusters-app/all-clusters-common/src/WhmDelegateImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/all-clusters-app/all-clusters-common/src/WhmManufacturer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/all-clusters-app/all-clusters-common/src/WhmManufacturer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Undo suggested change from Boris as idx needed in the loop * Update examples/all-clusters-app/all-clusters-common/src/WhmDelegateImpl.cpp Co-authored-by: lpbeliveau-silabs <[email protected]> * Address review comments --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Junior Martinez <[email protected]> Co-authored-by: C Freeman <[email protected]> Co-authored-by: Alex Tsitsiura <[email protected]> Co-authored-by: Pradip De <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: jamesharrow <[email protected]> Co-authored-by: lpbeliveau-silabs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the water heater management cluster to the all clusters app and provide support testing against the water heater management test scripts.
This PR follows on from: