Water heater management server impl #34230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xml using Alchemy and spec commit: dbf7c6dd7206fa4a4647f8a6218325fbe6c8ec6c Note more DEM PRs are yet to merge.
…neration of a top-level list in the PowerAdjustmentCapability attribute.
…ich causes ZAP to complain about more than 2 byte length.
…ustementCapability list moving one level below.
…s when running zap_regen_all.py. Also used Alchemy --featureXML.
…rs.zap as a test.
…ller-clusters.zap (put back Thread Border Router, removed Water Heater)
…cluster (to avoid compile failures).
…ves the error. [Should be a duplicate of PR project-chip#34000 when that merges.
|
PR #34230: Size comparison from 6e31453 to 678aa7f Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Please split this into three separate PRs, which will make reviewing this much easier:
- A PR that adds the XML and the minimal other changes needed to get that XML hooked up to codegen, plus the resulting generated code.
- A PR that adds the src/app/clusters implementation bits.
- A PR that adds the example app.
… boost command validation
… boost command validation
|
PR #34230: Size comparison from b88ac27 to eb6de20 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34230: Size comparison from b88ac27 to 1528700 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34230: Size comparison from 3bc5667 to 4929eef Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34230: Size comparison from 3bc5667 to 8e84752 Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34230: Size comparison from 3bc5667 to 433d33d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34230: Size comparison from f6022e4 to c33273b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34230: Size comparison from c91a779 to 8ce0b33 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34230: Size comparison from ba949bf to 1101eea Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
This PR is now out of date and has been superseded by the #34456 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the water heater management cluster (issue Fixes #34341)
The spec for this can be found at https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/WaterHeaterManagement.adoc.
The water heater management cluster definition ([src/app/zap-templates/zcl/data-model/chip/energy-evse-cluster.xml) is being reviewed under https://github.com//pull/33910.
The PR also includes an water heater management example app for review.