Update ember-compatibility-functions to always return error codes instead of directly encoding them as success.
#34392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkpoint logic and error statuses are duplicated between Engine.cpp and ember-compatibility-functions. This change makes the code consistent either error out (with something that the engine can handle) or encode success.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34392: Size comparison from b88ac27 to 7f6b56e Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 18, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
…/connectedhomeip into let_backup_and_error_to_caller
|
PR #34392: Size comparison from ded3be7 to e9dafd3 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
|
PR #34392: Size comparison from 99ea3e6 to bb4e20d Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34392: Size comparison from 4ec643c to 0afc4c6 Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #34392: Size comparison from 5e274d9 to 1ce0820 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jul 18, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…nstead of directly encoding them as success. (project-chip#34392) * Let the read implementation return the error status for failed reads. The checkpoint logic and error statuses are duplicated between Engine.cpp and ember-compatibility-functions. This change makes the code consistent either error out (with something that the engine can handle) or encode success. * Fix typo * One more code cleanup for return values. No more global statuses * minor update to kick ci * Update src/app/util/ember-compatibility-functions.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the read implementation in
Engine.cppdo the work of encoding failures and doing rollback/restore.Without this, the logic was duplicated in ember-compatibility-functions which results in extra complexity and flash usage.
For reference, https://github.com/project-chip/connectedhomeip/blob/master/src/app/reporting/Engine.cpp#L205 has logic for handling errors and generally it has to accept them because it has special handling for out of space.