minor update to kick ci

project-chip · Jul 18, 2024 · 7f6b56e · 7f6b56e
1 parent 8dffdf8
commit 7f6b56e
Showing 1 changed file with 8 additions and 32 deletions.
diff --git a/src/app/util/ember-compatibility-functions.cpp b/src/app/util/ember-compatibility-functions.cpp
@@ -455,14 +455,8 @@ CHIP_ERROR ReadSingleClusterData(const SubjectDescriptor & aSubjectDescriptor, b
         uint8_t dataLength = gEmberAttributeIOBufferSpan[0];
         if (dataLength == 0xFF)
         {
-            if (isNullable)
-            {
-                ReturnErrorOnFailure(writer->PutNull(tag));
-            }
-            else
-            {
-                return CHIP_ERROR_INCORRECT_STATE;
-            }
+            VerifyOrReturnError(isNullable, CHIP_ERROR_INCORRECT_STATE);
+            ReturnErrorOnFailure(writer->PutNull(tag));
         }
         else
         {
@@ -477,14 +471,8 @@ CHIP_ERROR ReadSingleClusterData(const SubjectDescriptor & aSubjectDescriptor, b
         memcpy(&dataLength, gEmberAttributeIOBufferSpan.data(), sizeof(dataLength));
         if (dataLength == 0xFFFF)
         {
-            if (isNullable)
-            {
-                ReturnErrorOnFailure(writer->PutNull(tag));
-            }
-            else
-            {
-                return CHIP_ERROR_INCORRECT_STATE;
-            }
+            VerifyOrReturnError(isNullable, CHIP_ERROR_INCORRECT_STATE);
+            ReturnErrorOnFailure(writer->PutNull(tag));
         }
         else
         {
@@ -498,14 +486,8 @@ CHIP_ERROR ReadSingleClusterData(const SubjectDescriptor & aSubjectDescriptor, b
         uint8_t dataLength   = gEmberAttributeIOBufferSpan[0];
         if (dataLength == 0xFF)
         {
-            if (isNullable)
-            {
-                ReturnErrorOnFailure(writer->PutNull(tag));
-            }
-            else
-            {
-                return CHIP_ERROR_INCORRECT_STATE;
-            }
+            VerifyOrReturnError(isNullable, CHIP_ERROR_INCORRECT_STATE);
+            ReturnErrorOnFailure(writer->PutNull(tag));
         }
         else
         {
@@ -519,14 +501,8 @@ CHIP_ERROR ReadSingleClusterData(const SubjectDescriptor & aSubjectDescriptor, b
         memcpy(&dataLength, gEmberAttributeIOBufferSpan.data(), sizeof(dataLength));
         if (dataLength == 0xFFFF)
         {
-            if (isNullable)
-            {
-                ReturnErrorOnFailure(writer->PutNull(tag));
-            }
-            else
-            {
-                return CHIP_ERROR_INCORRECT_STATE;
-            }
+            VerifyOrReturnError(isNullable, CHIP_ERROR_INCORRECT_STATE);
+            ReturnErrorOnFailure(writer->PutNull(tag));
         }
         else
         {