Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Darwin: Prohibit static initializers in Matter.framework" #34286

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Revert "Darwin: Prohibit static initializers in Matter.framework" #34286

merged 1 commit into from
Jul 10, 2024

Conversation

woody-apple
Copy link
Contributor

Reverts #34168

This is causing crashes at mDNS discovery time for some reason.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

PR #34286: Size comparison from d38ab9a to 7f1daf3

Full report (40 builds for efr32, linux, mbed, nrfconnect, telink, tizen)
platform target config section d38ab9a 7f1daf3 change % change
efr32 lighting-app BRD4187C FLASH 924456 924548 92 0.0
RAM 137516 137528 12 0.0
lock-app BRD4338a FLASH 733244 733556 312 0.0
RAM 207900 207896 -4 -0.0
window-app BRD4187C FLASH 1012300 1012620 320 0.0
RAM 129620 129632 12 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2529936 2530592 656 0.0
RAM 125072 125112 40 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5590606 5591470 864 0.0
RAM 492176 492184 8 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5061520 5062128 608 0.0
RAM 235488 235496 8 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4478256 4478960 704 0.0
RAM 212744 212832 88 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11769703 11770311 608 0.0
RAM 545946 545954 8 0.0
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10850375 10850951 576 0.0
RAM 542754 542794 40 0.0
fabric-bridge-app debug unknown 4528 4528 0 0.0
FLASH 4243776 4244480 704 0.0
RAM 198808 198832 24 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5382594 5383298 704 0.0
RAM 224096 224136 40 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4541600 4542304 704 0.0
RAM 200240 200248 8 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4197648 4198368 720 0.0
RAM 194520 194544 24 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4323200 4323728 528 0.0
RAM 199176 199168 -8 -0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2804925 2805389 464 0.0
RAM 153000 153008 8 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5605920 5606384 464 0.0
RAM 341760 341800 40 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9939582 9940030 448 0.0
RAM 402128 402136 8 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502500 1502644 144 0.0
RAM 226640 226656 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882448 882560 112 0.0
RAM 142109 142229 120 0.1
nrf7002dk_nrf5340_cpuapp FLASH 952948 953060 112 0.0
RAM 140537 140657 120 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 827984 828088 104 0.0
RAM 141023 141127 104 0.1
telink air-quality-sensor-app tlsr9528a_retention FLASH 632734 632894 160 0.0
RAM 50424 50528 104 0.2
all-clusters-app tlsr9118bdk40d FLASH 658574 658756 182 0.0
RAM 148296 148408 112 0.1
all-clusters-minimal-app tlsr9528a FLASH 778900 779070 170 0.0
RAM 113116 113220 104 0.1
bridge-app tlsr9258a FLASH 675720 675890 170 0.0
RAM 95200 95304 104 0.1
contact-sensor-app tlsr9528a_retention FLASH 634318 634478 160 0.0
RAM 50468 50572 104 0.2
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720192 720362 170 0.0
RAM 77044 77148 104 0.1
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613722 613892 170 0.0
RAM 144532 144636 104 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801474 801644 170 0.0
RAM 102936 103040 104 0.1
lock-app-dfu tlsr9528a FLASH 665886 666056 170 0.0
RAM 69756 69860 104 0.1
ota-requestor-app tlsr9258a FLASH 695050 695220 170 0.0
RAM 94924 95028 104 0.1
pump-app tlsr9518adk80d FLASH 616582 616752 170 0.0
RAM 56848 56952 104 0.2
pump-controller-app tlsr9518adk80d FLASH 606966 607136 170 0.0
RAM 56648 56752 104 0.2
shell tlsr9518adk80d FLASH 466316 466380 64 0.0
RAM 72460 72484 24 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640936 641096 160 0.0
RAM 52096 52200 104 0.2
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650792 650962 170 0.0
RAM 60284 60388 104 0.2
thermostat tlsr9518adk80d FLASH 625856 626026 170 0.0
RAM 56980 57084 104 0.2
window-covering tlsr9118bdk40d FLASH 519116 519286 170 0.0
RAM 97696 97800 104 0.1
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1638592 1639124 532 0.0
RAM 48540 48548 8 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16235438 16236990 1552 0.0
RAM 7138096 7138480 384 0.0

@woody-apple
Copy link
Contributor Author

Apple QA just verified this revert fixes the crash.

@woody-apple woody-apple added hotfix urgent fix needed, can bypass review crash labels Jul 10, 2024
@woody-apple woody-apple merged commit 3c96d5b into master Jul 10, 2024
131 of 132 checks passed
@woody-apple woody-apple deleted the revert-34168-darwin-no-inits branch July 10, 2024 21:20
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 18, 2024
@woody-apple @j-ororke
Revert "Darwin: Prohibit static initializers in Matter.framework" (pr…
ece513c 
…oject-chip#34286)

This reverts commit f199ba4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@anush-apple anush-apple Awaiting requested review from anush-apple

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app crash darwin hotfix urgent fix needed, can bypass review lib messaging platform review - pending support
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @anush-apple